From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ranjith Thangavel <ranjithece24@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
abbotti@mev.co.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] comedi: ni_6527: Fix coding style - use BIT macro
Date: Mon, 16 Nov 2015 17:33:57 +0300 [thread overview]
Message-ID: <20151116143356.GH18797@mwanda> (raw)
In-Reply-To: <1447506803-11050-1-git-send-email-ranjithece24@gmail.com>
On Sat, Nov 14, 2015 at 06:43:23PM +0530, Ranjith Thangavel wrote:
> @@ -221,11 +223,11 @@ static int ni6527_intr_cmdtest(struct comedi_device *dev,
>
> /* Step 1 : check if triggers are trivially valid */
>
> - err |= comedi_check_trigger_src(&cmd->start_src, TRIG_NOW);
> - err |= comedi_check_trigger_src(&cmd->scan_begin_src, TRIG_OTHER);
> - err |= comedi_check_trigger_src(&cmd->convert_src, TRIG_FOLLOW);
> - err |= comedi_check_trigger_src(&cmd->scan_end_src, TRIG_COUNT);
> - err |= comedi_check_trigger_src(&cmd->stop_src, TRIG_COUNT);
> + err |= cfc_check_trigger_src(&cmd->start_src, TRIG_NOW);
> + err |= cfc_check_trigger_src(&cmd->scan_begin_src, TRIG_OTHER);
> + err |= cfc_check_trigger_src(&cmd->convert_src, TRIG_FOLLOW);
> + err |= cfc_check_trigger_src(&cmd->scan_end_src, TRIG_COUNT);
> + err |= cfc_check_trigger_src(&cmd->stop_src, TRIG_COUNT);
>
> if (err)
> return 1;
This part looks to be included by mistake.
regards,
dan carpenter
next prev parent reply other threads:[~2015-11-16 14:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-14 13:13 [PATCH] comedi: ni_6527: Fix coding style - use BIT macro Ranjith Thangavel
2015-11-16 14:33 ` Dan Carpenter [this message]
2015-11-18 16:02 ` Ian Abbott
-- strict thread matches above, loose matches on Subject: below --
2015-11-16 16:56 Ranjith Thangavel
2015-11-18 16:36 ` Ian Abbott
2015-11-11 16:14 Ranjith Thangavel
2015-11-12 17:59 ` Ian Abbott
2015-11-09 17:57 Ranjith T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151116143356.GH18797@mwanda \
--to=dan.carpenter@oracle.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ranjithece24@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox