From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752018AbbKPOeK (ORCPT ); Mon, 16 Nov 2015 09:34:10 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:48324 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750929AbbKPOeI (ORCPT ); Mon, 16 Nov 2015 09:34:08 -0500 Date: Mon, 16 Nov 2015 17:33:57 +0300 From: Dan Carpenter To: Ranjith Thangavel Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, abbotti@mev.co.uk, linux-kernel@vger.kernel.org Subject: Re: [PATCH] comedi: ni_6527: Fix coding style - use BIT macro Message-ID: <20151116143356.GH18797@mwanda> References: <1447506803-11050-1-git-send-email-ranjithece24@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447506803-11050-1-git-send-email-ranjithece24@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 14, 2015 at 06:43:23PM +0530, Ranjith Thangavel wrote: > @@ -221,11 +223,11 @@ static int ni6527_intr_cmdtest(struct comedi_device *dev, > > /* Step 1 : check if triggers are trivially valid */ > > - err |= comedi_check_trigger_src(&cmd->start_src, TRIG_NOW); > - err |= comedi_check_trigger_src(&cmd->scan_begin_src, TRIG_OTHER); > - err |= comedi_check_trigger_src(&cmd->convert_src, TRIG_FOLLOW); > - err |= comedi_check_trigger_src(&cmd->scan_end_src, TRIG_COUNT); > - err |= comedi_check_trigger_src(&cmd->stop_src, TRIG_COUNT); > + err |= cfc_check_trigger_src(&cmd->start_src, TRIG_NOW); > + err |= cfc_check_trigger_src(&cmd->scan_begin_src, TRIG_OTHER); > + err |= cfc_check_trigger_src(&cmd->convert_src, TRIG_FOLLOW); > + err |= cfc_check_trigger_src(&cmd->scan_end_src, TRIG_COUNT); > + err |= cfc_check_trigger_src(&cmd->stop_src, TRIG_COUNT); > > if (err) > return 1; This part looks to be included by mistake. regards, dan carpenter