From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ranjith Thangavel <ranjithece24@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
abbotti@mev.co.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] comedi: dmm32at: Fix coding style - use BIT macro
Date: Mon, 16 Nov 2015 17:43:31 +0300 [thread overview]
Message-ID: <20151116144331.GI18797@mwanda> (raw)
In-Reply-To: <1447521036-23550-1-git-send-email-ranjithece24@gmail.com>
This one is buggy. For example:
> -#define DMM32AT_FIFO_STATUS_PAGE_MASK (3 << 0)
> +#define DMM32AT_FIFO_STATUS_PAGE_MASK 0
There are other bugs as well. Please, be more careful.
regards,
dan carpenter
next prev parent reply other threads:[~2015-11-16 14:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-14 17:10 [PATCH] comedi: dmm32at: Fix coding style - use BIT macro Ranjith Thangavel
2015-11-16 14:43 ` Dan Carpenter [this message]
2015-11-18 16:26 ` Ian Abbott
2015-11-18 16:34 ` Ian Abbott
2015-11-19 7:51 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2015-11-16 17:09 Ranjith Thangavel
2015-11-16 17:21 ` Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151116144331.GI18797@mwanda \
--to=dan.carpenter@oracle.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ranjithece24@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox