From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752896AbbKPOns (ORCPT <rfc822;w@1wt.eu>);
	Mon, 16 Nov 2015 09:43:48 -0500
Received: from aserp1040.oracle.com ([141.146.126.69]:19888 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751361AbbKPOnr (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 16 Nov 2015 09:43:47 -0500
Date: Mon, 16 Nov 2015 17:43:31 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ranjith Thangavel <ranjithece24@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, abbotti@mev.co.uk,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] comedi: dmm32at: Fix coding style - use BIT macro
Message-ID: <20151116144331.GI18797@mwanda>
References: <1447521036-23550-1-git-send-email-ranjithece24@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1447521036-23550-1-git-send-email-ranjithece24@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: userv0022.oracle.com [156.151.31.74]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This one is buggy.  For example:

> -#define DMM32AT_FIFO_STATUS_PAGE_MASK	(3 << 0)
> +#define DMM32AT_FIFO_STATUS_PAGE_MASK	0

There are other bugs as well.  Please, be more careful.

regards,
dan carpenter