From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753377AbbKPSnL (ORCPT ); Mon, 16 Nov 2015 13:43:11 -0500 Received: from mx2.suse.de ([195.135.220.15]:48851 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752657AbbKPSnJ (ORCPT ); Mon, 16 Nov 2015 13:43:09 -0500 Date: Mon, 16 Nov 2015 18:43:04 +0000 From: Mel Gorman To: mhocko@kernel.org Cc: Andrew Morton , David Rientjes , linux-mm@kvack.org, LKML , Michal Hocko Subject: Re: [PATCH 1/2] mm: get rid of __alloc_pages_high_priority Message-ID: <20151116173754.GG19677@suse.de> References: <1447680139-16484-1-git-send-email-mhocko@kernel.org> <1447680139-16484-2-git-send-email-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1447680139-16484-2-git-send-email-mhocko@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 16, 2015 at 02:22:18PM +0100, mhocko@kernel.org wrote: > From: Michal Hocko > > __alloc_pages_high_priority doesn't do anything special other than it > calls get_page_from_freelist and loops around GFP_NOFAIL allocation > until it succeeds. It would be better if the first part was done in > __alloc_pages_slowpath where we modify the zonelist because this would > be easier to read and understand. Opencoding the function into its only > caller allows to simplify it a bit as well. > > This patch doesn't introduce any functional changes. > > Signed-off-by: Michal Hocko Acked-by: Mel Gorman -- Mel Gorman SUSE Labs