public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>
Cc: linux-kernel@vger.kernel.org
Subject: [BUG] checkpatch: false positive for commits with quote characters
Date: Mon, 16 Nov 2015 14:43:21 -0800	[thread overview]
Message-ID: <20151116224321.GR8456@google.com> (raw)

Hi,

What is the Blessed (TM) style for referencing commits that have quote
characters in their subject line? e.g., this commit:

commit 43163022927b6e7d202a7e6f939c3f392465494d
Author: Brian Norris <computersforpeace@gmail.com>
Date:   Tue May 19 14:38:22 2015 -0700

    mtd: m25p80: allow arbitrary OF matching for "jedec,spi-nor"

Checkpatch reports false positive errors like this:

  ERROR: Please use git commit description style 'commit <12+ chars of
  sha1> ("<title line>")'

when I try to reference it on this patch:

  https://lkml.org/lkml/2015/11/16/826

I understand the double quoting is a little nasty to parse, but I think
that just means we should relax the regexes in checkpatch.pl. I could
try to patch myself, but I figured I'd just follow checkpatch's advice
instead:

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Brian

             reply	other threads:[~2015-11-16 22:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-16 22:43 Brian Norris [this message]
2015-11-17 17:48 ` [BUG] checkpatch: false positive for commits with quote characters Joe Perches
2015-11-17 18:03   ` Brian Norris
2015-12-04  0:13     ` Brian Norris
2015-12-04  0:29       ` Joe Perches
2015-12-04  0:36         ` Joe Perches
2015-12-04  1:39           ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151116224321.GR8456@google.com \
    --to=computersforpeace@gmail.com \
    --cc=apw@canonical.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox