Re: [Patch v4 2/2] media: v4l: ti-vpe: Document CAL driver

[Benoit Parrot <bparrot@ti.com>]

Rob Herring <robh@kernel.org> wrote on Mon [2015-Nov-16 09:26:16 -0600]:
> On Sun, Nov 15, 2015 at 05:53:48PM -0600, Benoit Parrot wrote:
> > Device Tree bindings for the Camera Adaptation Layer (CAL) driver
> 
> Bindings are for h/w blocks, not drivers...

OK I'll fix that.

> 
> > 
> > Signed-off-by: Benoit Parrot <bparrot@ti.com>
> > ---
> >  Documentation/devicetree/bindings/media/ti-cal.txt | 70 ++++++++++++++++++++++
> >  1 file changed, 70 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/media/ti-cal.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/media/ti-cal.txt b/Documentation/devicetree/bindings/media/ti-cal.txt
> > new file mode 100644
> > index 000000000000..680efadb6208
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/ti-cal.txt
> > @@ -0,0 +1,70 @@
> > +Texas Instruments DRA72x CAMERA ADAPTATION LAYER (CAL)
> > +------------------------------------------------------
> > +
> > +The Camera Adaptation Layer (CAL) is a key component for image capture
> > +applications. The capture module provides the system interface and the
> > +processing capability to connect CSI2 image-sensor modules to the
> > +DRA72x device.
> > +
> > +Required properties:
> > +- compatible: must be "ti,cal"
> 
> Needs to be more specific.

See potential patch below.

> 
> > +- reg:	physical base address and length of the registers set for the 4
> > +	memory regions required;
> 
> Please list what the 4 regions are.

See potential patch below.

> 
> > +- reg-names: name associated with the memory regions described is <reg>;
> 
> Please list the names.

See potential patch below.

> 
> > +- interrupts: should contain IRQ line for the CAL;
> > +
> > +CAL supports 2 camera port nodes on MIPI bus. Each CSI2 camera port nodes
> > +should contain a 'port' child node with child 'endpoint' node. Please
> > +refer to the bindings defined in
> > +Documentation/devicetree/bindings/media/video-interfaces.txt.
> > +
> > +Example:
> > +	cal: cal@4845b000 {
> > +		compatible = "ti,cal";
> > +		ti,hwmods = "cal";
> > +		reg = <0x4845B000 0x400>,
> > +		      <0x4845B800 0x40>,
> > +		      <0x4845B900 0x40>,
> > +		      <0x4A002e94 0x4>;
> > +		reg-names = "cal_top",
> > +			    "cal_rx_core0",
> > +			    "cal_rx_core1",
> > +			    "camerrx_control";
> > +		interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>;
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +		csi2_0: port@0 {
> 
> Multiple ports should be under a ports node.

The video-interfaces.txt bindings doc state:
"All 'port' nodes can be grouped under optional 'ports' node"
Doesn't that mean that 'ports' is then optional has show in the csi2
example provide in the same documents?

> 
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			reg = <0>;
> > +			endpoint {
> > +				slave-mode;
> > +				remote-endpoint = <&ar0330_1>;
> > +			};
> > +		};
> > +		csi2_1: port@1 {
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			reg = <1>;
> > +		};
> > +	};
> > +
> > +	i2c5: i2c@4807c000 {
> > +		ar0330@10 {
> > +			compatible = "ti,ar0330";
> > +			reg = <0x10>;
> > +
> > +			port {
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +
> > +				ar0330_1: endpoint {
> > +					reg = <0>;
> > +					clock-lanes = <1>;
> > +					data-lanes = <0 2 3 4>;
> > +					remote-endpoint = <&csi2_0>;
> > +				};
> > +			};
> > +		};
> > +	};
> > -- 
> > 1.8.5.1
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe devicetree" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html

Potential fix for the above comments:


diff --git a/Documentation/devicetree/bindings/media/ti-cal.txt b/Documentation/devicetree/bindings/media/ti-cal.txt
index 680efadb6208..ef6f88de38c0 100644
--- a/Documentation/devicetree/bindings/media/ti-cal.txt
+++ b/Documentation/devicetree/bindings/media/ti-cal.txt
@@ -7,10 +7,11 @@ processing capability to connect CSI2 image-sensor modules to the
 DRA72x device.
 
 Required properties:
-- compatible: must be "ti,cal"
-- reg:	physical base address and length of the registers set for the 4
-	memory regions required;
-- reg-names: name associated with the memory regions described is <reg>;
+- compatible: must be "ti,dra72-cal"
+- reg:	CAL Top level, Receiver Core #0, Receiver Core #1 and Camera RX
+	control address space
+- reg-names: cal_top, cal_rx_core0, cal_rx_core1, and camerrx_control
+	     registers
 - interrupts: should contain IRQ line for the CAL;
 
 CAL supports 2 camera port nodes on MIPI bus. Each CSI2 camera port nodes
@@ -20,7 +21,7 @@ Documentation/devicetree/bindings/media/video-interfaces.txt.
 
 Example:
 	cal: cal@4845b000 {
-		compatible = "ti,cal";
+		compatible = "ti,dra72-cal";
 		ti,hwmods = "cal";
 		reg = <0x4845B000 0x400>,
 		      <0x4845B800 0x40>,


Regards,
Benoit