From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752686AbbKQAUd (ORCPT ); Mon, 16 Nov 2015 19:20:33 -0500 Received: from LGEAMRELO12.lge.com ([156.147.23.52]:40304 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751236AbbKQAUc (ORCPT ); Mon, 16 Nov 2015 19:20:32 -0500 X-Original-SENDERIP: 156.147.1.127 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 165.244.98.76 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 10.177.227.17 X-Original-MAILFROM: namhyung@kernel.org Date: Tue, 17 Nov 2015 09:20:27 +0900 From: Namhyung Kim To: Steven Rostedt CC: Arnaldo Carvalho de Melo , LKML , Ingo Molnar Subject: Re: [PATCH v2] tools lib traceevents: Fix output of %llu for 64 bit values read on 32 bit machines Message-ID: <20151117002027.GC1865@sejong> References: <20151116153310.326c1558@gandalf.local.home> <20151116172302.0a9326b5@gandalf.local.home> <20151116172516.4b79b109@gandalf.local.home> MIME-Version: 1.0 In-Reply-To: <20151116172516.4b79b109@gandalf.local.home> User-Agent: Mutt/1.5.24 (2015-08-30) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB03/LGE/LG Group(Release 8.5.3FP3HF583 | August 9, 2013) at 2015/11/17 09:20:27, Serialize by Router on LGEKRMHUB03/LGE/LG Group(Release 8.5.3FP3HF583 | August 9, 2013) at 2015/11/17 09:20:27, Serialize complete at 2015/11/17 09:20:27 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 16, 2015 at 05:25:16PM -0500, Steven Rostedt wrote: > > When a long value is read on 32 bit machines for 64 bit output, the parsing > needs to change "%lu" into "%llu", as the value is read natively. > > Unfortunately, if "%llu" is already there, the code will add another "l" to > it and fail to parse it properly. > > Cc: stable@vger.kernel.org > Signed-off-by: Steven Rostedt Acked-by: Namhyung Kim What about the opposite case? Maybe we need something like this? Thanks, Namhyung diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c index 4d885934b919..afc32fb17d1e 100644 --- a/tools/lib/traceevent/event-parse.c +++ b/tools/lib/traceevent/event-parse.c @@ -4906,6 +4906,17 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct event memmove(p+1, p, strlen(p)+1); else if (strcmp(format, "%p") == 0) strcpy(format, "0x%llx"); + } else if (pevent->long_size == 4 && ls == 1 && + sizeof(long) != 4) { + char *p; + + ls = 0; + /* make %l into % */ + p = strchr(format, 'l'); + if (p) + memmove(p, p+1, strlen(p)); + else if (strcmp(format, "%p") == 0) + strcpy(foramt, "0x%x"); } switch (ls) { case -2: