From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Ranjith Thangavel <ranjithece24@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
abbotti@mev.co.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] comedi: dmm32at: Fix coding style - use BIT macro
Date: Tue, 17 Nov 2015 21:54:06 +0530 [thread overview]
Message-ID: <20151117162406.GA32098@sudip-pc> (raw)
In-Reply-To: <1447694308-7724-1-git-send-email-ranjithece24@gmail.com>
On Mon, Nov 16, 2015 at 10:48:27PM +0530, Ranjith Thangavel wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator, usleep_range is preferred over
> udelay - coding style issue
>
> Signed-off-by: Ranjith Thangavel <ranjithece24@gmail.com>
> ---
I am not seeing any change related to udelay. Can you see?
regards
sudip
next prev parent reply other threads:[~2015-11-17 16:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 17:18 [PATCH 1/2] comedi: dmm32at: Fix coding style - use BIT macro Ranjith Thangavel
2015-11-16 17:18 ` [PATCH 2/2] " Ranjith Thangavel
2015-11-17 16:26 ` Sudip Mukherjee
2015-11-17 16:24 ` Sudip Mukherjee [this message]
2015-11-18 16:41 ` [PATCH 1/2] " Ian Abbott
2015-11-18 16:45 ` Hartley Sweeten
2015-11-18 17:02 ` Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151117162406.GA32098@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ranjithece24@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox