From: Rob Herring <robh@kernel.org>
To: Cory Tusar <cory.tusar@pid1solutions.com>
Cc: pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
agust@denx.de, gregkh@linuxfoundation.org, jic23@kernel.org,
vz@mleia.com, broonie@kernel.org, afd@ti.com, andrew@lunn.ch,
Chris.Healy@zii.aero, Keith.Vennel@zii.aero,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/7] misc: eeprom: 93xx46: Add DT binding for Atmel AT93C46D devices.
Date: Tue, 17 Nov 2015 14:56:52 -0600 [thread overview]
Message-ID: <20151117205652.GA8990@rob-hp-laptop> (raw)
In-Reply-To: <1447733796-15546-5-git-send-email-cory.tusar@pid1solutions.com>
On Mon, Nov 16, 2015 at 11:16:33PM -0500, Cory Tusar wrote:
> This commit adds a compatible string to the eeprom_93xx46 devicetree
> bindings in support of Atmel AT93C46D devices.
>
> Signed-off-by: Cory Tusar <cory.tusar@pid1solutions.com>
> ---
> Documentation/devicetree/bindings/misc/eeprom-93xx46.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
> index ba493a8..34a0cc2 100644
> --- a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
> +++ b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
> @@ -1,7 +1,7 @@
> EEPROMs (SPI) compatible with Microchip Technology 93xx46 family.
>
> Required properties:
> -- compatible : "eeprom-93xx46"
> +- compatible : "eeprom-93xx46", "atmel,at93c46d"
This needs to be clear that it should be the opposite order. Something
like this:
compatible: One of the following:
"atmel,at93c46d"
Followed by "eeprom-93xx46"
> - data-size : number of data bits per word (either 8 or 16)
>
> Optional properties:
> --
> 2.4.10
>
next prev parent reply other threads:[~2015-11-17 20:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 4:16 [PATCH 0/7] Devicetree support for misc/eeprom/eeprom_93xx46 Cory Tusar
2015-11-17 4:16 ` [PATCH 1/7] misc: eeprom: 93xx46: Fix 16-bit read and write accesses Cory Tusar
2015-11-17 4:16 ` [PATCH 2/7] misc: eeprom: 93xx46: Add DT bindings to eeprom_93xx46 driver Cory Tusar
2015-11-17 20:53 ` Rob Herring
2015-11-17 21:14 ` Cory Tusar
2015-11-17 4:16 ` [PATCH 3/7] misc: eeprom: 93xx46: Implement eeprom_93xx46 DT bindings Cory Tusar
2015-11-17 4:16 ` [PATCH 4/7] misc: eeprom: 93xx46: Add DT binding for Atmel AT93C46D devices Cory Tusar
2015-11-17 20:56 ` Rob Herring [this message]
2015-11-17 21:15 ` Cory Tusar
2015-11-17 4:16 ` [PATCH 5/7] misc: eeprom: 93xx46: Add quirks to support Atmel AT93C46D device Cory Tusar
2015-11-17 4:16 ` [PATCH 6/7] misc: eeprom: 93xx46: Add DT binding for a GPIO 'select' line Cory Tusar
2015-11-17 20:59 ` Rob Herring
2015-11-17 21:19 ` Cory Tusar
2015-11-17 4:16 ` [PATCH 7/7] misc: eeprom: 93xx46: Add support " Cory Tusar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151117205652.GA8990@rob-hp-laptop \
--to=robh@kernel.org \
--cc=Chris.Healy@zii.aero \
--cc=Keith.Vennel@zii.aero \
--cc=afd@ti.com \
--cc=agust@denx.de \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=cory.tusar@pid1solutions.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jic23@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox