From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
ast@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf test: Add bpf-output event
Date: Wed, 18 Nov 2015 17:50:39 -0300 [thread overview]
Message-ID: <20151118205039.GX22729@kernel.org> (raw)
In-Reply-To: <20151118192603.GA374@us.ibm.com>
Em Wed, Nov 18, 2015 at 11:26:04AM -0800, Sukadev Bhattiprolu escreveu:
> >From 8f71d55dd3e27e6ca2138e3ed6dfeceb1c00a426 Mon Sep 17 00:00:00 2001
> From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> Date: Wed, 18 Nov 2015 19:06:08 -0500
> Subject: [PATCH] perf test: Add bpf-output event
>
> The kernel has added support for 'PERF_COUNT_SW_BPF_OUTPUT' but that is
> missing from the perf tool. Among other things, results in the 'roundtrip
> evsel->name check' test case of 'perf test' failing on Powerpc.
Next time can you please state if this is for this merge window or for
the next?
Will apply it for perf/core, for the next merge window.
- Arnaldo
> Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> ---
> tools/perf/util/evsel.c | 1 +
> tools/perf/util/parse-events.c | 4 ++++
> tools/perf/util/parse-events.l | 1 +
> 3 files changed, 6 insertions(+)
>
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index 397fb4e..2033632 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -342,6 +342,7 @@ const char *perf_evsel__sw_names[PERF_COUNT_SW_MAX] = {
> "alignment-faults",
> "emulation-faults",
> "dummy",
> + "bpf-output",
> };
>
> static const char *__perf_evsel__sw_name(u64 config)
> diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
> index e48d9da..40ae92a 100644
> --- a/tools/perf/util/parse-events.c
> +++ b/tools/perf/util/parse-events.c
> @@ -124,6 +124,10 @@ struct event_symbol event_symbols_sw[PERF_COUNT_SW_MAX] = {
> .symbol = "dummy",
> .alias = "",
> },
> + [PERF_COUNT_SW_BPF_OUTPUT] = {
> + .symbol = "bpf-output",
> + .alias = "",
> + },
> };
>
> #define __PERF_EVENT_FIELD(config, name) \
> diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l
> index 58c5831..380298d 100644
> --- a/tools/perf/util/parse-events.l
> +++ b/tools/perf/util/parse-events.l
> @@ -238,6 +238,7 @@ cpu-migrations|migrations { return sym(yyscanner, PERF_TYPE_SOFTWARE, PERF_COU
> alignment-faults { return sym(yyscanner, PERF_TYPE_SOFTWARE, PERF_COUNT_SW_ALIGNMENT_FAULTS); }
> emulation-faults { return sym(yyscanner, PERF_TYPE_SOFTWARE, PERF_COUNT_SW_EMULATION_FAULTS); }
> dummy { return sym(yyscanner, PERF_TYPE_SOFTWARE, PERF_COUNT_SW_DUMMY); }
> +bpf-output { return sym(yyscanner, PERF_TYPE_SOFTWARE, PERF_COUNT_SW_BPF_OUTPUT); }
>
> /*
> * We have to handle the kernel PMU event cycles-ct/cycles-t/mem-loads/mem-stores separately.
> --
> 1.8.3.1
next prev parent reply other threads:[~2015-11-18 20:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 19:26 [PATCH] perf test: Add bpf-output event Sukadev Bhattiprolu
2015-11-18 20:50 ` Arnaldo Carvalho de Melo [this message]
2015-11-18 23:14 ` Alexei Starovoitov
2015-11-19 1:37 ` Wangnan (F)
2015-11-19 23:29 ` Sukadev Bhattiprolu
2015-11-20 2:22 ` Wangnan (F)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151118205039.GX22729@kernel.org \
--to=acme@kernel.org \
--cc=ast@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox