From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757179AbbKRWYu (ORCPT ); Wed, 18 Nov 2015 17:24:50 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:37349 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756501AbbKRWYt (ORCPT ); Wed, 18 Nov 2015 17:24:49 -0500 Date: Wed, 18 Nov 2015 14:24:46 -0800 From: Stephen Boyd To: Sudip Mukherjee Cc: Michael Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH] clk: versatile: fix memory leak Message-ID: <20151118222446.GG32672@codeaurora.org> References: <1447681600-14120-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447681600-14120-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/16, Sudip Mukherjee wrote: > If of_clk_parent_fill() fails then we printed an error message and > returned. But we missed freeing sp810. > > Signed-off-by: Sudip Mukherjee > --- Applied to clk-next We don't need that error message on allocation failure either. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project