From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Javi Merino <javi.merino@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
John Stultz <john.stultz@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
Arjan van de Ven <arjan@linux.intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Len Brown <len.brown@intel.com>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Paul Turner <pjt@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH 4/4] sched: add trace event for idle injection
Date: Thu, 19 Nov 2015 07:35:23 -0800 [thread overview]
Message-ID: <20151119073523.656c2fcb@icelake> (raw)
In-Reply-To: <20151119143934.GB9512@e104805>
On Thu, 19 Nov 2015 14:39:35 +0000
Javi Merino <javi.merino@arm.com> wrote:
> > +
>
> One minor nit: can you use key=value (i.e. "throttled=%d") instead for
> consistency with the rest of this file?
>
will do.
> Other than that, I know that Peter suggested an enum for the action,
> but wouldn't it be better to create an EVENT_CLASS and subclass the
> three actions from it? Something like:
I agree, it will be more readable in the trace.
thanks you
prev parent reply other threads:[~2015-11-19 15:36 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 19:53 [PATCH 0/4] CFS idle injection Jacob Pan
2015-11-13 19:53 ` [PATCH 1/4] ktime: add a roundup function Jacob Pan
2015-11-13 20:11 ` John Stultz
2015-11-13 22:33 ` Jacob Pan
2015-11-13 20:13 ` Thomas Gleixner
2015-11-13 22:36 ` Jacob Pan
2015-11-13 19:53 ` [PATCH 2/4] timer: relax tick stop in idle entry Jacob Pan
2015-11-13 20:22 ` Thomas Gleixner
2015-11-13 22:24 ` Jacob Pan
2015-11-16 15:06 ` Thomas Gleixner
2015-11-16 21:51 ` Jacob Pan
2015-11-16 22:01 ` Thomas Gleixner
2015-11-17 0:09 ` Jacob Pan
2015-11-19 17:43 ` Jacob Pan
2015-11-19 19:06 ` Peter Zijlstra
2015-11-19 19:21 ` Jacob Pan
2015-11-19 19:59 ` Peter Zijlstra
2015-11-19 23:41 ` Jacob Pan
2015-11-16 22:31 ` Paul E. McKenney
2015-11-16 23:05 ` Jacob Pan
2015-11-16 23:15 ` Jacob Pan
2015-11-16 23:28 ` Paul E. McKenney
2015-11-16 23:32 ` Arjan van de Ven
2015-11-16 23:40 ` Jacob Pan
2015-11-17 0:00 ` Paul E. McKenney
2015-11-16 22:32 ` Josh Triplett
2015-11-16 23:26 ` Paul E. McKenney
2015-11-17 1:41 ` Josh Triplett
2015-11-17 2:53 ` Paul E. McKenney
2015-11-17 2:57 ` Arjan van de Ven
2015-11-17 5:04 ` Paul E. McKenney
2015-11-17 10:24 ` Peter Zijlstra
2015-11-17 12:57 ` Jacob Pan
2015-11-17 13:49 ` Paul E. McKenney
2015-11-13 19:53 ` [PATCH 3/4] sched: introduce synchronized idle injection Jacob Pan
2015-11-13 20:23 ` kbuild test robot
2015-11-18 8:36 ` Ingo Molnar
2015-11-18 10:35 ` Peter Zijlstra
2015-11-18 12:27 ` Morten Rasmussen
2015-11-18 12:49 ` Peter Zijlstra
2015-11-18 14:04 ` Morten Rasmussen
2015-11-18 14:52 ` Jacob Pan
2015-11-18 15:09 ` Morten Rasmussen
2015-11-18 15:11 ` Jacob Pan
2015-11-18 15:21 ` Thomas Gleixner
2015-11-18 17:03 ` Jacob Pan
2015-11-18 16:04 ` Morten Rasmussen
2015-11-27 9:17 ` Ingo Molnar
2015-11-18 14:10 ` Jacob Pan
2015-11-27 9:17 ` Ingo Molnar
2015-12-02 17:28 ` Jacob Pan
2015-11-18 14:19 ` Arjan van de Ven
2015-11-18 15:44 ` Morten Rasmussen
2015-11-18 15:51 ` Arjan van de Ven
2015-11-19 17:24 ` Morten Rasmussen
2015-11-19 20:09 ` Peter Zijlstra
2015-11-20 9:45 ` Thomas Gleixner
2015-11-20 10:20 ` Peter Zijlstra
2015-11-20 10:58 ` Thomas Gleixner
2015-11-20 12:54 ` Peter Zijlstra
2015-11-20 18:53 ` Thomas Gleixner
2016-01-11 21:50 ` Jacob Pan
2016-01-19 12:06 ` Ingo Molnar
2016-01-19 18:00 ` Jacob Pan
2015-11-24 11:38 ` Jacob Pan
2015-11-23 17:59 ` Jacob Pan
2015-11-23 17:56 ` Javi Merino
2015-11-23 18:07 ` Peter Zijlstra
2015-11-24 9:12 ` Javi Merino
2015-11-24 10:09 ` Peter Zijlstra
2015-11-24 11:10 ` Jacob Pan
2015-11-24 12:00 ` Javi Merino
2015-11-24 18:22 ` Jacob Pan
2015-11-25 9:41 ` Javi Merino
2015-11-13 19:53 ` [PATCH 4/4] sched: add trace event for " Jacob Pan
2015-11-13 20:10 ` kbuild test robot
2015-11-19 14:39 ` Javi Merino
2015-11-19 15:35 ` Jacob Pan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151119073523.656c2fcb@icelake \
--to=jacob.jun.pan@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=edubezval@gmail.com \
--cc=javi.merino@arm.com \
--cc=john.stultz@linaro.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rostedt@goodmis.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).