From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Zapolskiy <vz@mleia.com>
Cc: Cory Tusar <cory.tusar@pid1solutions.com>,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
agust@denx.de, gregkh@linuxfoundation.org, jic23@kernel.org,
broonie@kernel.org, afd@ti.com, Chris.Healy@zii.aero,
Keith.Vennel@zii.aero, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select' line.
Date: Thu, 19 Nov 2015 18:15:45 +0100 [thread overview]
Message-ID: <20151119171545.GF25345@lunn.ch> (raw)
In-Reply-To: <564DFE69.6000203@mleia.com>
On Thu, Nov 19, 2015 at 06:52:57PM +0200, Vladimir Zapolskiy wrote:
> On 19.11.2015 16:18, Andrew Lunn wrote:
> >>> #ifdef CONFIG_OF
> >>> +static void select_assert(void *context)
> >>> +{
> >>> + struct eeprom_93xx46_dev *edev = context;
> >>> +
> >>> + gpiod_set_value_cansleep(gpio_to_desc(edev->pdata->select_gpio), 1);
> >>
> >> I would suggest to use gpio_set_value()
> >
> > Could you explain why?
> >
> > Maybe this gpio is on an SPI GPIO expander?
>
> My point is that gpio_*() interface, gpio_set_value() or
> gpio_set_value_cansleep(), might be preferred is this particular case.
Ah, O.K, yes, avoid the gpio_to_desc() call.
Agreed.
Andrew
next prev parent reply other threads:[~2015-11-19 17:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 3:29 [PATCH v2 0/5] Devicetree support for misc/eeprom/eeprom_93xx46 Cory Tusar
2015-11-19 3:29 ` [PATCH v2 1/5] misc: eeprom_93xx46: Fix 16-bit read and write accesses Cory Tusar
2015-11-19 3:29 ` [PATCH v2 2/5] Documentation: devicetree: Add DT bindings to eeprom_93xx46 driver Cory Tusar
2015-11-19 14:59 ` Rob Herring
2015-11-19 17:30 ` Cory Tusar
2015-11-19 3:29 ` [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT bindings Cory Tusar
2015-11-19 5:50 ` Vladimir Zapolskiy
2015-11-19 14:00 ` Andrew F. Davis
2015-11-19 16:14 ` Vladimir Zapolskiy
2015-11-21 4:53 ` Cory Tusar
2015-11-21 4:40 ` Cory Tusar
2015-11-21 18:36 ` Vladimir Zapolskiy
2015-11-23 18:24 ` Cory Tusar
2015-11-19 3:29 ` [PATCH v2 4/5] misc: eeprom_93xx46: Add quirks to support Atmel AT93C46D device Cory Tusar
2015-11-19 5:59 ` Vladimir Zapolskiy
2015-11-23 17:44 ` Cory Tusar
2015-11-19 3:29 ` [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select' line Cory Tusar
2015-11-19 6:05 ` Vladimir Zapolskiy
2015-11-19 14:18 ` Andrew Lunn
2015-11-19 16:52 ` Vladimir Zapolskiy
2015-11-19 17:15 ` Andrew Lunn [this message]
2015-11-25 4:53 ` Cory Tusar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151119171545.GF25345@lunn.ch \
--to=andrew@lunn.ch \
--cc=Chris.Healy@zii.aero \
--cc=Keith.Vennel@zii.aero \
--cc=afd@ti.com \
--cc=agust@denx.de \
--cc=broonie@kernel.org \
--cc=cory.tusar@pid1solutions.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jic23@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox