From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758745AbbKSRgV (ORCPT ); Thu, 19 Nov 2015 12:36:21 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:45035 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751685AbbKSRgU (ORCPT ); Thu, 19 Nov 2015 12:36:20 -0500 Date: Thu, 19 Nov 2015 09:36:19 -0800 From: Greg KH To: Anjali Menon Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: android: ion: Fixing NULL comparison style Message-ID: <20151119173619.GA15443@kroah.com> References: <1447952393-8867-1-git-send-email-cse.anjalimenon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447952393-8867-1-git-send-email-cse.anjalimenon@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 19, 2015 at 10:29:53PM +0530, Anjali Menon wrote: > Using checkpatch.pl fixed the check. > > CHECK: Comparison to NULL could be written "!data" > > Signed-off-by: Anjali Menon > --- > drivers/staging/android/ion/compat_ion.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/android/ion/compat_ion.c b/drivers/staging/android/ion/compat_ion.c > index a402fda..8a0df9c 100644 > --- a/drivers/staging/android/ion/compat_ion.c > +++ b/drivers/staging/android/ion/compat_ion.c > @@ -137,7 +137,7 @@ long compat_ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) > > data32 = compat_ptr(arg); > data = compat_alloc_user_space(sizeof(*data)); > - if (data == NULL) > + if ("!data" == NULL) I don't think you compiled this code :(