From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch -next] rcu: off by one in gp_state_getname()
Date: Thu, 19 Nov 2015 22:34:09 +0300 [thread overview]
Message-ID: <20151119193408.GA24110@mwanda> (raw)
It should be >= ARRAY_SIZE() instead of > ARRAY_SIZE().
Fixes: 6231da675578 ('rcu: Print symbolic name for ->gp_state')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 6a5e1c4..6559b3c 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -1203,7 +1203,7 @@ static void record_gp_stall_check_time(struct rcu_state *rsp)
*/
static char *gp_state_getname(short gs)
{
- if (gs < 0 || gs > ARRAY_SIZE(gp_state_names))
+ if (gs < 0 || gs >= ARRAY_SIZE(gp_state_names))
return "???";
return gp_state_names[gs];
}
next reply other threads:[~2015-11-19 19:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 19:34 Dan Carpenter [this message]
2015-11-19 21:18 ` [patch -next] rcu: off by one in gp_state_getname() Paul E. McKenney
2015-11-20 10:30 ` Dan Carpenter
2015-11-20 11:33 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151119193408.GA24110@mwanda \
--to=dan.carpenter@oracle.com \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox