* [PATCH] null_blk: fix ifnullfree.cocci warnings
[not found] <201511200651.cpbRddKu%fengguang.wu@intel.com>
@ 2015-11-19 22:09 ` kbuild test robot
0 siblings, 0 replies; only message in thread
From: kbuild test robot @ 2015-11-19 22:09 UTC (permalink / raw)
To: Matias Bjørling
Cc: kbuild-all, Jens Axboe, Akinobu Mita, NeilBrown, Ross Zwisler,
Mike Krinkin, Luis R. Rodriguez, linux-kernel
drivers/block/null_blk.c:850:2-20: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
NULL check before some freeing functions is not needed.
Based on checkpatch warning
"kfree(NULL) is safe this check is probably not required"
and kfreeaddr.cocci by Julia Lawall.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
CC: Matias Bjørling <m@bjorling.me>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
null_blk.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/block/null_blk.c
+++ b/drivers/block/null_blk.c
@@ -846,8 +846,7 @@ static void __exit null_exit(void)
}
mutex_unlock(&lock);
- if (ppa_cache)
- kmem_cache_destroy(ppa_cache);
+ kmem_cache_destroy(ppa_cache);
}
module_init(null_init);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-11-19 22:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <201511200651.cpbRddKu%fengguang.wu@intel.com>
2015-11-19 22:09 ` [PATCH] null_blk: fix ifnullfree.cocci warnings kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox