From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759378AbbKSWLL (ORCPT ); Thu, 19 Nov 2015 17:11:11 -0500 Received: from mga03.intel.com ([134.134.136.65]:52400 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758649AbbKSWLJ (ORCPT ); Thu, 19 Nov 2015 17:11:09 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,319,1444719600"; d="scan'208";a="842796879" Date: Fri, 20 Nov 2015 06:09:57 +0800 From: kbuild test robot To: Matias =?iso-8859-1?Q?Bj=F8rling?= Cc: kbuild-all@01.org, Jens Axboe , Akinobu Mita , NeilBrown , Ross Zwisler , Mike Krinkin , "Luis R. Rodriguez" , linux-kernel@vger.kernel.org Subject: [PATCH] null_blk: fix ifnullfree.cocci warnings Message-ID: <20151119220957.GA51853@xian> References: <201511200651.cpbRddKu%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201511200651.cpbRddKu%fengguang.wu@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org drivers/block/null_blk.c:850:2-20: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci CC: Matias Bjørling Signed-off-by: Fengguang Wu --- null_blk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/block/null_blk.c +++ b/drivers/block/null_blk.c @@ -846,8 +846,7 @@ static void __exit null_exit(void) } mutex_unlock(&lock); - if (ppa_cache) - kmem_cache_destroy(ppa_cache); + kmem_cache_destroy(ppa_cache); } module_init(null_init);