From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161430AbbKSXDI (ORCPT ); Thu, 19 Nov 2015 18:03:08 -0500 Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:11940 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161258AbbKSXDG (ORCPT ); Thu, 19 Nov 2015 18:03:06 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2D/CQCUVE5WPALtLHleKAECgxCBQoZdpRYBAQEBAQEGizmFLIJ9gRCGCQICAQECgUtNAQEBAQEBBwEBAQFAAT+ENAEBAQQ6HCMQCAMVAwklDwUlAwcaE4gtwDEBAQEHAgEgGYV0hD+BBogkgRUFjR2JL40mnE+Eeyo0hSABAQE Date: Fri, 20 Nov 2015 10:02:32 +1100 From: Dave Chinner To: Al Viro Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Neil Brown , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 06/10] [vfs] don't put symlink bodies in pagecache into highmem Message-ID: <20151119230232.GF19199@dastard> References: <20151117225752.GZ22011@ZenIV.linux.org.uk> <1447801246-24588-6-git-send-email-viro@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447801246-24588-6-git-send-email-viro@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 17, 2015 at 11:00:42PM +0000, Al Viro wrote: > From: Al Viro > > kmap() in page_follow_link_light() needed to go - allowing to hold > an arbitrary number of kmaps for long is a great way to deadlocking > the system. > > new helper (inode_nohigh(inode)) needs to be used for pagecache inode_nohighmem() seems like a better name as it's self-documenting at the call site. Cheers, Dave. -- Dave Chinner david@fromorbit.com