From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162856AbbKTOUU (ORCPT ); Fri, 20 Nov 2015 09:20:20 -0500 Received: from mail.kernel.org ([198.145.29.136]:49590 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162311AbbKTOUR (ORCPT ); Fri, 20 Nov 2015 09:20:17 -0500 Date: Fri, 20 Nov 2015 08:20:13 -0600 From: Rob Herring To: Leilk Liu Cc: Mark Brown , Mark Rutland , Matthias Brugger , Sascha Hauer , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 2/4] spi: mediatek: remove unrequired description Message-ID: <20151120142013.GA498@rob-hp-laptop> References: <1447986080-31410-1-git-send-email-leilk.liu@mediatek.com> <1447986080-31410-2-git-send-email-leilk.liu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447986080-31410-2-git-send-email-leilk.liu@mediatek.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 20, 2015 at 10:21:17AM +0800, Leilk Liu wrote: > cs-gpios isn't required with patch "spi: mediatek: single > device does not require cs_gpios", so modify the description. > > Signed-off-by: Leilk Liu This could use a better subject. Try to make subjects specific enough they would only ever apply to the change. Acked-by: Rob Herring > --- > .../devicetree/bindings/spi/spi-mt65xx.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt > index fba8334..60a183c 100644 > --- a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt > +++ b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt > @@ -29,7 +29,7 @@ Required properties: > muxes clock, and "spi-clk" for the clock gate. > > Optional properties: > --cs-gpios: see spi-bus.txt, only required for MT8173. > +-cs-gpios: see spi-bus.txt. > > - mediatek,pad-select: specify which pins group(ck/mi/mo/cs) spi > controller used. This is an array, the element value should be 0~3, > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html