Re: [PATCH 1/1] toshiba_acpi: Propagate the hotkey value via genetlink

[Darren Hart <dvhart@infradead.org>]

On Sun, Nov 15, 2015 at 08:33:46PM -0700, Azael Avalos wrote:
> The driver uses genetlink to inform userspace of events generated by
> the system, but the data passed is always zero as there is no data to
> pass, except for the hotkey event.
> 
> This patch propagates the hotkey value via genetlink so userspace can
> make use of it.

Which keys were not working previously?

My concern is that we introduce new events that then get "double handled".

Some more context about the problem experienced and how this resolves it would
be helpful.

Thanks,

> 
> Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
> ---
>  drivers/platform/x86/toshiba_acpi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c
> index 7f71f8f..63c231a 100644
> --- a/drivers/platform/x86/toshiba_acpi.c
> +++ b/drivers/platform/x86/toshiba_acpi.c
> @@ -2966,7 +2966,8 @@ static void toshiba_acpi_notify(struct acpi_device *acpi_dev, u32 event)
>  
>  	acpi_bus_generate_netlink_event(acpi_dev->pnp.device_class,
>  					dev_name(&acpi_dev->dev),
> -					event, 0);
> +					event, (event == 0x80) ?
> +					dev->last_key_event : 0);
>  }
>  
>  #ifdef CONFIG_PM_SLEEP
> -- 
> 2.6.2
> 
> 

-- 
Darren Hart
Intel Open Source Technology Center