public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Ray Jui <rjui@broadcom.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	Simran Rai <ssimran@broadcom.com>
Subject: Re: [PATCH 2/3] clk: iproc: Add support for Cygnus audio clocks
Date: Fri, 20 Nov 2015 16:21:19 -0800	[thread overview]
Message-ID: <20151121002119.GA28998@codeaurora.org> (raw)
In-Reply-To: <1447870089-2382-3-git-send-email-rjui@broadcom.com>

On 11/18, Ray Jui wrote:
> diff --git a/drivers/clk/bcm/clk-iproc.h b/drivers/clk/bcm/clk-iproc.h
> index 8988de7..e2a7748 100644
> --- a/drivers/clk/bcm/clk-iproc.h
> +++ b/drivers/clk/bcm/clk-iproc.h
> @@ -194,5 +215,11 @@ void __init iproc_asiu_setup(struct device_node *node,
>  			     const struct iproc_asiu_div *div,
>  			     const struct iproc_asiu_gate *gate,
>  			     unsigned int num_clks);
> +void __init iproc_audiopll_clk_setup(struct device_node *node,
> +				const struct iproc_pll_ctrl *pll_ctrl,
> +				const struct iproc_pll_vco_param *vco,
> +				unsigned int num_vco_entries,
> +				const struct iproc_clk_ctrl *clk_ctrl,
> +				unsigned int num_clks);

We don't need __init in header files. And is this even used or
defined anywhere?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2015-11-21  0:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-18 18:08 [PATCH 0/3] Add Cygnus audio clock support Ray Jui
2015-11-18 18:08 ` [PATCH 1/3] Documentation: dt-bindings: Add DT bindings for Cygnus audio clock Ray Jui
2015-11-18 18:08 ` [PATCH 2/3] clk: iproc: Add support for Cygnus audio clocks Ray Jui
2015-11-21  0:21   ` Stephen Boyd [this message]
2015-11-21  0:57     ` Ray Jui
2015-11-21  1:05       ` Stephen Boyd
2015-11-18 18:08 ` [PATCH 3/3] ARM: dts: enable audio clock support for Cygnus Ray Jui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151121002119.GA28998@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=rjui@broadcom.com \
    --cc=ssimran@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox