public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Kyeongdon Kim <kyeongdon.kim@lge.com>
Cc: minchan@kernel.org, akpm@linux-foundation.org, ngupta@vflare.org,
	linux-kernel@vger.kernel.org, sergey.senozhatsky@gmail.com,
	sergey.senozhatsky.work@gmail.com
Subject: Re: [PATCH v2] zram: Prevent page allocation failure during zcomp_strm_alloc
Date: Sat, 21 Nov 2015 11:15:43 +0900	[thread overview]
Message-ID: <20151121021542.GB3121@swordfish> (raw)
In-Reply-To: <20151121021059.GA3121@swordfish>

On (11/21/15 11:10), Sergey Senozhatsky wrote:
> Cc Andrew
> 
> On (11/20/15 19:02), Kyeongdon Kim wrote:
> > When we're using LZ4 multi compression streams for zram swap,
> > we found out page allocation failure message in system running test.
> > That was not only once, but a few(2 - 5 times per test).
> > Also, some failure cases were continually occurring to try allocation
> > order 3.
> > 
> > In order to make parallel compression private data, we should call
> > kzalloc() with order 2/3 in runtime(lzo/lz4). But if there is no order
> >  2/3 size memory in that time, page allocation fails.
> > This patch makes to use vmalloc() as fallback of kmalloc(), this
> > prevents page alloc failure warning.
> > 
> > After this, we never found warning message in running test, also
> > It could reduce process startup latency about 60-120ms in each case.
> 
> Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> 

with the only nit that the subject should be "try kmalloc() before vmalloc()"
or similar, not "prevent page allocation failure", I think.

	-ss

  reply	other threads:[~2015-11-21  2:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20 10:02 [PATCH v2] zram: Prevent page allocation failure during zcomp_strm_alloc Kyeongdon Kim
2015-11-21  2:10 ` Sergey Senozhatsky
2015-11-21  2:15   ` Sergey Senozhatsky [this message]
2015-11-21  9:37     ` Sergey Senozhatsky
2015-11-23  2:15 ` Minchan Kim
2015-11-23  3:14   ` Sergey Senozhatsky
2015-11-23  3:35     ` Sergey Senozhatsky
  -- strict thread matches above, loose matches on Subject: below --
2015-11-23  4:18 Minchan Kim
2015-11-23  7:43 ` Sergey Senozhatsky
2015-11-23  8:13   ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151121021542.GB3121@swordfish \
    --to=sergey.senozhatsky.work@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=kyeongdon.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minchan@kernel.org \
    --cc=ngupta@vflare.org \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox