From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753198AbbKWDEm (ORCPT ); Sun, 22 Nov 2015 22:04:42 -0500 Received: from mail.kernel.org ([198.145.29.136]:47691 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752985AbbKWDEk (ORCPT ); Sun, 22 Nov 2015 22:04:40 -0500 Date: Mon, 23 Nov 2015 11:04:05 +0800 From: Shawn Guo To: Stefan Agner Cc: kernel@pengutronix.de, mturquette@baylibre.com, sboyd@codeaurora.org, galak@codeaurora.org, ijc+devicetree@hellion.org.uk, mark.rutland@arm.com, pawel.moll@arm.com, robh+dt@kernel.org, Li.Xiubo@freescale.com, zidan.wang@freescale.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] ARM: dts: vf610: fix clock definition for SAI2 Message-ID: <20151123030405.GC13744@tiger> References: <1445141122-14183-1-git-send-email-stefan@agner.ch> <1445141122-14183-2-git-send-email-stefan@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445141122-14183-2-git-send-email-stefan@agner.ch> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 17, 2015 at 09:05:21PM -0700, Stefan Agner wrote: > So far, only the bus clock has been assigned, but in reality the > SAI IP has for clock inputs. The driver has been updated to s/for/four Will fix it up when applying. Shawn > make use of the additional clock inputs by c3ecef21c3f2 ("ASoC: > fsl_sai: add sai master mode support"). Due to a bug in the > clock tree, the audio clock has been enabled none the less by > the specified bus clock (see "ARM: imx: clk-vf610: fix SAI > clock tree"), which made master mode even without the proper > clock assigned working. > > This patch completes the clock definition for SAI2. On Vybrid, > only two MCLK out of the four options are available (the first > being the bus clock itself). See chapter 8.10.1.2.3 of the > Vybrid Reference manual ("SAI transmitter and receiver options > for MCLK selection"). Note: The audio clocks are only required > in master mode. > > Signed-off-by: Stefan Agner > --- > arch/arm/boot/dts/vfxxx.dtsi | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi > index 6865137..c2a4d1c 100644 > --- a/arch/arm/boot/dts/vfxxx.dtsi > +++ b/arch/arm/boot/dts/vfxxx.dtsi > @@ -178,8 +178,10 @@ > compatible = "fsl,vf610-sai"; > reg = <0x40031000 0x1000>; > interrupts = <86 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&clks VF610_CLK_SAI2>; > - clock-names = "sai"; > + clocks = <&clks VF610_CLK_SAI2>, > + <&clks VF610_CLK_SAI2_DIV>, > + <&clks 0>, <&clks 0>; > + clock-names = "bus", "mclk1", "mclk2", "mclk3"; > dma-names = "tx", "rx"; > dmas = <&edma0 0 21>, > <&edma0 0 20>; > -- > 2.6.1 >