From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Kyeongdon Kim <kyeongdon.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
ngupta@vflare.org, linux-kernel@vger.kernel.org,
sergey.senozhatsky@gmail.com, sergey.senozhatsky.work@gmail.com
Subject: Re: [PATCH v2] zram: Prevent page allocation failure during zcomp_strm_alloc
Date: Mon, 23 Nov 2015 17:13:40 +0900 [thread overview]
Message-ID: <20151123081340.GE7449@swordfish> (raw)
In-Reply-To: <20151123074337.GD7449@swordfish>
On (11/23/15 16:43), Sergey Senozhatsky wrote:
[..]
> agree. we also would want to switch from vzalloc() to
> __vmalloc_node_flags(size, NUMA_NO_NODE,
> GFP_NOIO | __GFP_HIGHMEM | __GFP_ZERO)
[..]
> > So, Kyeongdon's patch will remove warning overhead and likely to
> > make zcomp_stram_alloc successful with vmalloc so I want to
> > roll it out first. And let's add a WARN_ON_ONCE to detect of
> > failure and rethink it when we receive such report.
hm... for k{z,m}alloc() it does reduce the warning overhead, but not
for vmalloc() -> warn_alloc_failed() [in theory]. So I guess, I'll
change vmalloc() to
__vmalloc(XXX,
GFP_NOIO | __GFP_NOWARN | __GFP_HIGHMEM | __GFP_ZERO,
PAGE_KERNEL);
/* passing __GFP_NOWARN */.
-ss
next prev parent reply other threads:[~2015-11-23 8:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 4:18 [PATCH v2] zram: Prevent page allocation failure during zcomp_strm_alloc Minchan Kim
2015-11-23 7:43 ` Sergey Senozhatsky
2015-11-23 8:13 ` Sergey Senozhatsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-11-20 10:02 Kyeongdon Kim
2015-11-21 2:10 ` Sergey Senozhatsky
2015-11-21 2:15 ` Sergey Senozhatsky
2015-11-21 9:37 ` Sergey Senozhatsky
2015-11-23 2:15 ` Minchan Kim
2015-11-23 3:14 ` Sergey Senozhatsky
2015-11-23 3:35 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151123081340.GE7449@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kyeongdon.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox