* [PATCH] dma-mapping: use offset_in_page macro
@ 2015-11-21 14:14 Geliang Tang
2015-11-23 13:22 ` Will Deacon
0 siblings, 1 reply; 3+ messages in thread
From: Geliang Tang @ 2015-11-21 14:14 UTC (permalink / raw)
To: Marek Szyprowski, Andrew Morton, Will Deacon, Arnd Bergmann,
Christian Borntraeger, Robin Murphy, Ricardo Ribalda Delgado
Cc: Geliang Tang, linux-kernel
Use offset_in_page macro instead of (addr & ~PAGE_MASK).
Signed-off-by: Geliang Tang <geliangtang@163.com>
---
include/linux/dma-mapping.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
index 3293f27..c0b27ff 100644
--- a/include/linux/dma-mapping.h
+++ b/include/linux/dma-mapping.h
@@ -131,10 +131,10 @@ static inline dma_addr_t dma_map_single_attrs(struct device *dev, void *ptr,
kmemcheck_mark_initialized(ptr, size);
BUG_ON(!valid_dma_direction(dir));
addr = ops->map_page(dev, virt_to_page(ptr),
- (unsigned long)ptr & ~PAGE_MASK, size,
+ offset_in_page(ptr), size,
dir, attrs);
debug_dma_map_page(dev, virt_to_page(ptr),
- (unsigned long)ptr & ~PAGE_MASK, size,
+ offset_in_page(ptr), size,
dir, addr, true);
return addr;
}
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dma-mapping: use offset_in_page macro
2015-11-21 14:14 [PATCH] dma-mapping: use offset_in_page macro Geliang Tang
@ 2015-11-23 13:22 ` Will Deacon
2015-11-23 14:46 ` Geliang Tang
0 siblings, 1 reply; 3+ messages in thread
From: Will Deacon @ 2015-11-23 13:22 UTC (permalink / raw)
To: Geliang Tang
Cc: Marek Szyprowski, Andrew Morton, Arnd Bergmann,
Christian Borntraeger, Robin Murphy, Ricardo Ribalda Delgado,
linux-kernel
On Sat, Nov 21, 2015 at 10:14:44PM +0800, Geliang Tang wrote:
> Use offset_in_page macro instead of (addr & ~PAGE_MASK).
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
> include/linux/dma-mapping.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
I don't know which tree you're aiming at, but:
Acked-by: Will Deacon <will.deacon@arm.com>
Will
> diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
> index 3293f27..c0b27ff 100644
> --- a/include/linux/dma-mapping.h
> +++ b/include/linux/dma-mapping.h
> @@ -131,10 +131,10 @@ static inline dma_addr_t dma_map_single_attrs(struct device *dev, void *ptr,
> kmemcheck_mark_initialized(ptr, size);
> BUG_ON(!valid_dma_direction(dir));
> addr = ops->map_page(dev, virt_to_page(ptr),
> - (unsigned long)ptr & ~PAGE_MASK, size,
> + offset_in_page(ptr), size,
> dir, attrs);
> debug_dma_map_page(dev, virt_to_page(ptr),
> - (unsigned long)ptr & ~PAGE_MASK, size,
> + offset_in_page(ptr), size,
> dir, addr, true);
> return addr;
> }
> --
> 2.5.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dma-mapping: use offset_in_page macro
2015-11-23 13:22 ` Will Deacon
@ 2015-11-23 14:46 ` Geliang Tang
0 siblings, 0 replies; 3+ messages in thread
From: Geliang Tang @ 2015-11-23 14:46 UTC (permalink / raw)
To: Will Deacon
Cc: Marek Szyprowski, Andrew Morton, Arnd Bergmann,
Christian Borntraeger, Robin Murphy, Ricardo Ribalda Delgado,
linux-kernel, Geliang Tang
On Mon, Nov 23, 2015 at 01:22:35PM +0000, Will Deacon wrote:
> On Sat, Nov 21, 2015 at 10:14:44PM +0800, Geliang Tang wrote:
> > Use offset_in_page macro instead of (addr & ~PAGE_MASK).
> >
> > Signed-off-by: Geliang Tang <geliangtang@163.com>
> > ---
> > include/linux/dma-mapping.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> I don't know which tree you're aiming at, but:
>
> Acked-by: Will Deacon <will.deacon@arm.com>
>
Thanks for your review. This patch is against linux-next tree.
- Geliang Tang
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-23 14:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-21 14:14 [PATCH] dma-mapping: use offset_in_page macro Geliang Tang
2015-11-23 13:22 ` Will Deacon
2015-11-23 14:46 ` Geliang Tang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox