* Re: [PATCH] perf callchain: Add missing parent_val initialization
2015-11-21 10:23 ` [PATCH] perf callchain: Add missing parent_val initialization Jiri Olsa
@ 2015-11-23 14:32 ` Arnaldo Carvalho de Melo
2015-11-26 8:20 ` [tip:perf/core] " tip-bot for Jiri Olsa
1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-11-23 14:32 UTC (permalink / raw)
To: Jiri Olsa
Cc: linux-kernel, Masami Hiramatsu, Jiri Olsa, Wang Nan, Namhyung Kim
Em Sat, Nov 21, 2015 at 11:23:55AM +0100, Jiri Olsa escreveu:
> Adding missing parent_val callchain_node initialization.
> It's causing segfault in perf top:
Thanks, applied.
- Arnaldo
> $ sudo perf top -g
> perf: Segmentation fault
> -------- backtrace --------
> free_callchain_node(+0x29) in perf [0x4a4b3e]
> free_callchain(+0x29) in perf [0x4a5a83]
> hist_entry__delete(+0x126) in perf [0x4c6649]
> hists__delete_entry(+0x6e) in perf [0x4c66dc]
> hists__decay_entries(+0x7d) in perf [0x4c6776]
> perf_top__sort_new_samples(+0x7c) in perf [0x436a78]
> hist_browser__run(+0xf2) in perf [0x507760]
> perf_evsel__hists_browse(+0x1da) in perf [0x507c8d]
> perf_evlist__tui_browse_hists(+0x3e) in perf [0x5088cf]
> display_thread_tui(+0x7f) in perf [0x437953]
> start_thread(+0xc5) in libpthread-2.21.so [0x7f7068fbb555]
> __clone(+0x6d) in libc-2.21.so [0x7f7066fc3b9d]
> [0x0]
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
> Link: http://lkml.kernel.org/n/tip-x001nhduevgcl78ublk9eaiz@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
> tools/perf/util/callchain.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h
> index 6e9b5f2099e1..8ac8f043004c 100644
> --- a/tools/perf/util/callchain.h
> +++ b/tools/perf/util/callchain.h
> @@ -143,6 +143,7 @@ extern __thread struct callchain_cursor callchain_cursor;
> static inline void callchain_init(struct callchain_root *root)
> {
> INIT_LIST_HEAD(&root->node.val);
> + INIT_LIST_HEAD(&root->node.parent_val);
>
> root->node.parent = NULL;
> root->node.hit = 0;
> --
> 2.4.3
^ permalink raw reply [flat|nested] 3+ messages in thread* [tip:perf/core] perf callchain: Add missing parent_val initialization
2015-11-21 10:23 ` [PATCH] perf callchain: Add missing parent_val initialization Jiri Olsa
2015-11-23 14:32 ` Arnaldo Carvalho de Melo
@ 2015-11-26 8:20 ` tip-bot for Jiri Olsa
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Jiri Olsa @ 2015-11-26 8:20 UTC (permalink / raw)
To: linux-tip-commits
Cc: jolsa, linux-kernel, tglx, wangnan0, jolsa, masami.hiramatsu.pt,
hpa, acme, namhyung, mingo
Commit-ID: 646a6e846c4dc3812c614fd061603b6db5b8d380
Gitweb: http://git.kernel.org/tip/646a6e846c4dc3812c614fd061603b6db5b8d380
Author: Jiri Olsa <jolsa@redhat.com>
AuthorDate: Sat, 21 Nov 2015 11:23:55 +0100
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 23 Nov 2015 18:31:25 -0300
perf callchain: Add missing parent_val initialization
Adding missing parent_val callchain_node initialization.
It's causing segfault in perf top:
$ sudo perf top -g
perf: Segmentation fault
-------- backtrace --------
free_callchain_node(+0x29) in perf [0x4a4b3e]
free_callchain(+0x29) in perf [0x4a5a83]
hist_entry__delete(+0x126) in perf [0x4c6649]
hists__delete_entry(+0x6e) in perf [0x4c66dc]
hists__decay_entries(+0x7d) in perf [0x4c6776]
perf_top__sort_new_samples(+0x7c) in perf [0x436a78]
hist_browser__run(+0xf2) in perf [0x507760]
perf_evsel__hists_browse(+0x1da) in perf [0x507c8d]
perf_evlist__tui_browse_hists(+0x3e) in perf [0x5088cf]
display_thread_tui(+0x7f) in perf [0x437953]
start_thread(+0xc5) in libpthread-2.21.so [0x7f7068fbb555]
__clone(+0x6d) in libc-2.21.so [0x7f7066fc3b9d]
[0x0]
Reported-and-Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Wang Nan <wangnan0@huawei.com>
Fixes: 4b3a3212233a ("perf hists browser: Support flat callchains")
Link: http://lkml.kernel.org/r/20151121102355.GA17313@krava.local
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/callchain.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h
index 6e9b5f2..8ac8f043 100644
--- a/tools/perf/util/callchain.h
+++ b/tools/perf/util/callchain.h
@@ -143,6 +143,7 @@ extern __thread struct callchain_cursor callchain_cursor;
static inline void callchain_init(struct callchain_root *root)
{
INIT_LIST_HEAD(&root->node.val);
+ INIT_LIST_HEAD(&root->node.parent_val);
root->node.parent = NULL;
root->node.hit = 0;
^ permalink raw reply related [flat|nested] 3+ messages in thread