From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754180AbbKWOtD (ORCPT ); Mon, 23 Nov 2015 09:49:03 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:34811 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753044AbbKWOtB (ORCPT ); Mon, 23 Nov 2015 09:49:01 -0500 Date: Mon, 23 Nov 2015 15:48:58 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Gabriele Mazzotta Cc: dvhart@infradead.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Andrei Borzenkov Subject: Re: [PATCH] dell-rbtn: Ignore ACPI notifications if device is suspended Message-ID: <20151123144858.GE24147@pali> References: <1448115375-7315-1-git-send-email-gabriele.mzt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1448115375-7315-1-git-send-email-gabriele.mzt@gmail.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday 21 November 2015 15:16:15 Gabriele Mazzotta wrote: > Some BIOSes unconditionally send an ACPI notification to RBTN when the > system is resuming from suspend. This makes dell-rbtn send an input > event to userspace as if a function key was pressed. Prevent this by > ignoring all the notifications received while the device is suspended. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=106031 > Signed-off-by: Gabriele Mazzotta Andrei Borzenkov (CCed) tested this patch and patch does not fix bug. Probably there is race condition and ACPI event is sent *after* function rbtn_resume is called. -- Pali Rohár pali.rohar@gmail.com