From: Lee Jones <lee.jones@linaro.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org, pbrobinson@gmail.com
Subject: Re: [PATCH] mfd: wm8994: Ensure that the whole MFD is built into a single module
Date: Mon, 23 Nov 2015 16:21:16 +0000 [thread overview]
Message-ID: <20151123162116.GB807@x1> (raw)
In-Reply-To: <1447951574-26253-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On Thu, 19 Nov 2015, Charles Keepax wrote:
> The MFD part of wm8994 consists of three files wm8994-core.c,
> wm8994-irq.c and wm8994-regmap.c only wm8994-core.c has a
> MODULE_DESCRIPTION / LICENSE. These were clearly intended to be built
> as a single module, but currently are not. This will lead to a tainted
> kernel when loading modules for wm8894-irq.c and wm8994-regmap.c because
> are missing a license.
>
> This patch fixes this issue by grouping the three files together into a
> single module.
>
> Reported-by: Peter Robinson <pbrobinson@gmail.com>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/Makefile | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index a8b76b8..99f93ab 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -61,7 +61,8 @@ wm8350-objs := wm8350-core.o wm8350-regmap.o wm8350-gpio.o
> wm8350-objs += wm8350-irq.o
> obj-$(CONFIG_MFD_WM8350) += wm8350.o
> obj-$(CONFIG_MFD_WM8350_I2C) += wm8350-i2c.o
> -obj-$(CONFIG_MFD_WM8994) += wm8994-core.o wm8994-irq.o wm8994-regmap.o
> +wm8994-objs := wm8994-core.o wm8994-irq.o wm8994-regmap.o
> +obj-$(CONFIG_MFD_WM8994) += wm8994.o
>
> obj-$(CONFIG_TPS6105X) += tps6105x.o
> obj-$(CONFIG_TPS65010) += tps65010.o
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2015-11-23 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 16:46 [PATCH] mfd: wm8994: Ensure that the whole MFD is built into a single module Charles Keepax
2015-11-22 10:18 ` Peter Robinson
2015-11-23 16:21 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151123162116.GB807@x1 \
--to=lee.jones@linaro.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbrobinson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox