From: Willy Tarreau <w@1wt.eu>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-arch@vger.kernel.org, josh@joshtriplett.org,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC] asm-generic: default BUG_ON(x) to "if(x) BUG()"
Date: Mon, 23 Nov 2015 17:52:19 +0100 [thread overview]
Message-ID: <20151123165219.GD768@1wt.eu> (raw)
In-Reply-To: <20151123163750.GT8644@n2100.arm.linux.org.uk>
On Mon, Nov 23, 2015 at 04:37:50PM +0000, Russell King - ARM Linux wrote:
> On Mon, Nov 23, 2015 at 05:33:59PM +0100, Willy Tarreau wrote:
> > I think you could do better by simply calling panic("BUG!") instead as
> > BUG() does. It will avoid the printk() call and pushing the file/line
> > number onto the stack. It will also probably not inflate the rodata this
> > way.
>
> Does that not depend on the architectures BUG() implementation? If an
> architecture implements it as a signalling illegal instruction and a
> lookup table, changing it to be a panic() would probably be more code.
That's a very good point, I didn't think about it and yes I think you're
right then (eg: when CONFIG_DEBUG_BUGVERBOSE is not set, x86 and arm will
only emit a single instruction).
Best regards,
Willy
next prev parent reply other threads:[~2015-11-23 16:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 16:25 [RFC] asm-generic: default BUG_ON(x) to "if(x) BUG()" Arnd Bergmann
2015-11-23 16:33 ` Willy Tarreau
2015-11-23 16:37 ` Russell King - ARM Linux
2015-11-23 16:52 ` Willy Tarreau [this message]
2015-11-23 16:52 ` Arnd Bergmann
2015-11-23 17:04 ` Willy Tarreau
2015-11-23 17:22 ` Russell King - ARM Linux
2015-11-23 19:29 ` Arnd Bergmann
2015-11-23 16:34 ` Russell King - ARM Linux
2015-11-23 20:16 ` Josh Triplett
2015-11-23 20:58 ` Arnd Bergmann
2015-11-23 21:17 ` Josh Triplett
2015-11-23 21:30 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151123165219.GD768@1wt.eu \
--to=w@1wt.eu \
--cc=arnd@arndb.de \
--cc=josh@joshtriplett.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox