From: Darren Hart <dvhart@infradead.org>
To: "Pali Rohár" <pali.rohar@gmail.com>,
"Rafael Wysocki" <rjw@rjwysocki.net>
Cc: Gabriele Mazzotta <gabriele.mzt@gmail.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andrei Borzenkov <arvidjaar@gmail.com>
Subject: Re: [PATCH] dell-rbtn: Ignore ACPI notifications if device is suspended
Date: Mon, 23 Nov 2015 11:24:43 -0800 [thread overview]
Message-ID: <20151123192443.GX7413@malice.jf.intel.com> (raw)
In-Reply-To: <20151123144858.GE24147@pali>
On Mon, Nov 23, 2015 at 03:48:58PM +0100, Pali Rohár wrote:
> On Saturday 21 November 2015 15:16:15 Gabriele Mazzotta wrote:
> > Some BIOSes unconditionally send an ACPI notification to RBTN when the
> > system is resuming from suspend. This makes dell-rbtn send an input
> > event to userspace as if a function key was pressed. Prevent this by
> > ignoring all the notifications received while the device is suspended.
> >
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=106031
> > Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
>
> Andrei Borzenkov (CCed) tested this patch and patch does not fix bug.
> Probably there is race condition and ACPI event is sent *after* function
> rbtn_resume is called.
I'm dropping this one until we can sort out a proper fix.
Is direction still needed from the ACPI side?
+Rafael
--
Darren Hart
Intel Open Source Technology Center
prev parent reply other threads:[~2015-11-23 19:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 14:16 [PATCH] dell-rbtn: Ignore ACPI notifications if device is suspended Gabriele Mazzotta
2015-11-21 19:18 ` Pali Rohár
2015-11-23 14:48 ` Pali Rohár
2015-11-23 19:24 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151123192443.GX7413@malice.jf.intel.com \
--to=dvhart@infradead.org \
--cc=arvidjaar@gmail.com \
--cc=gabriele.mzt@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox