From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752929AbbKWTYq (ORCPT ); Mon, 23 Nov 2015 14:24:46 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:37662 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751065AbbKWTYo (ORCPT ); Mon, 23 Nov 2015 14:24:44 -0500 Date: Mon, 23 Nov 2015 11:24:43 -0800 From: Darren Hart To: Pali =?iso-8859-1?Q?Roh=E1r?= , Rafael Wysocki Cc: Gabriele Mazzotta , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Andrei Borzenkov Subject: Re: [PATCH] dell-rbtn: Ignore ACPI notifications if device is suspended Message-ID: <20151123192443.GX7413@malice.jf.intel.com> References: <1448115375-7315-1-git-send-email-gabriele.mzt@gmail.com> <20151123144858.GE24147@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151123144858.GE24147@pali> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 23, 2015 at 03:48:58PM +0100, Pali Rohár wrote: > On Saturday 21 November 2015 15:16:15 Gabriele Mazzotta wrote: > > Some BIOSes unconditionally send an ACPI notification to RBTN when the > > system is resuming from suspend. This makes dell-rbtn send an input > > event to userspace as if a function key was pressed. Prevent this by > > ignoring all the notifications received while the device is suspended. > > > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=106031 > > Signed-off-by: Gabriele Mazzotta > > Andrei Borzenkov (CCed) tested this patch and patch does not fix bug. > Probably there is race condition and ACPI event is sent *after* function > rbtn_resume is called. I'm dropping this one until we can sort out a proper fix. Is direction still needed from the ACPI side? +Rafael -- Darren Hart Intel Open Source Technology Center