From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752995AbbKXEF0 (ORCPT ); Mon, 23 Nov 2015 23:05:26 -0500 Received: from m12-18.163.com ([220.181.12.18]:55116 "EHLO m12-18.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752839AbbKXEFY (ORCPT ); Mon, 23 Nov 2015 23:05:24 -0500 Date: Mon, 23 Nov 2015 20:05:06 -0800 From: Geliang Tang To: Don Fry , Christoph Hellwig , Andrew Morton Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Geliang Tang Subject: Re: [PATCH] pcnet32: fix a logic error with pci_set_dma_mask Message-ID: <20151124040506.GA2694@ubuntu> References: <20151012.053814.1870650163021801761.davem@davemloft.net> <1445486486.5667.33.camel@Lunix2.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445486486.5667.33.camel@Lunix2.home> User-Agent: Mutt/1.5.21 (2010-09-15) X-CM-TRANSID: EsCowECZ40X14VNWbPACEw--.24622S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7WrWkXF1xCFWrJr4fJF4fXwb_yoW8JFyxpw 4fCa48Cw1jkFySkr1qka15WF1Ykws8Xwnagrn3tF9F9r4q9r18WrWaq3W7Gry3Kr1Fkayx XrsFgFyfXr15Ja7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07UafO7UUUUU= X-Originating-IP: [218.17.162.133] X-CM-SenderInfo: 5jhoxtpqjwt0rj6rljoofrz/xtbByhe8mVO+gFzVGAAAsE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 21, 2015 at 09:01:26PM -0700, Don Fry wrote: > On Mon, 2015-10-12 at 05:38 -0700, David Miller wrote: > > From: Geliang Tang > > Date: Fri, 9 Oct 2015 03:45:39 -0700 > > > > > pcnet32 can't work on my machine recently. It says "architecture > > > does not support 32bit PCI busmaster DMA". There is a logic error > > > in it: pci_set_dma_mask() return 0 means return successfully. > > > > > > Signed-off-by: Geliang Tang > > > > This driver doesn't call pci_set_dma_mask() in any of my tree(s). > I failed. My system with pcnet32 boards was down with a dead power > supply and a visual review was not good enough. I missed that > pci_dma_supported returns 1 on success and pci_set_dma_mask returns 0 on > success. The original patch needs to have the ! removed as Geliang Tang > points out. > > Acked-by: Don Fry Hi: It has been a month since I submitted this patch. I'm wondering is it still valid and wether it will be applied? A recent commit targeting at the same problem (commit 1a47de6 various: fix pci_set_dma_mask return value checking) has been applied. But my commit, which I reported and submitted earlier, hasn't been applied. I'd like to know if there's anything wrong with it? Thank you! - Geliang Tang