From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752799AbbKXGkT (ORCPT ); Tue, 24 Nov 2015 01:40:19 -0500 Received: from mail.kernel.org ([198.145.29.136]:59324 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752084AbbKXGkS (ORCPT ); Tue, 24 Nov 2015 01:40:18 -0500 Date: Tue, 24 Nov 2015 14:39:47 +0800 From: Shawn Guo To: Bai Ping Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] clk: imx: add 'is_prepared' clk_ops callback for pllv3 clk Message-ID: <20151124063947.GL11999@tiger> References: <1446487569-20757-1-git-send-email-b51503@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446487569-20757-1-git-send-email-b51503@freescale.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 03, 2015 at 02:06:09AM +0800, Bai Ping wrote: > Add 'is_prepared' callback function for pllv3 type clk to make sure when > the system is bootup, the unused clk is in a known state to match the > prepare count info. > > Signed-off-by: Bai Ping Please resend the patch with following clk maintainers and list on copy. Also remember to add Lucas' Reviewed-by: tag. COMMON CLK FRAMEWORK M: Michael Turquette M: Stephen Boyd L: linux-clk@vger.kernel.org Shawn > --- > drivers/clk/imx/clk-pllv3.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c > index 6addf8f..c05c43d 100644 > --- a/drivers/clk/imx/clk-pllv3.c > +++ b/drivers/clk/imx/clk-pllv3.c > @@ -97,6 +97,16 @@ static void clk_pllv3_unprepare(struct clk_hw *hw) > writel_relaxed(val, pll->base); > } > > +static int clk_pllv3_is_prepared(struct clk_hw *hw) > +{ > + struct clk_pllv3 *pll = to_clk_pllv3(hw); > + > + if (readl_relaxed(pll->base) & BM_PLL_LOCK) > + return 1; > + > + return 0; > +} > + > static unsigned long clk_pllv3_recalc_rate(struct clk_hw *hw, > unsigned long parent_rate) > { > @@ -139,6 +149,7 @@ static int clk_pllv3_set_rate(struct clk_hw *hw, unsigned long rate, > static const struct clk_ops clk_pllv3_ops = { > .prepare = clk_pllv3_prepare, > .unprepare = clk_pllv3_unprepare, > + .is_prepared = clk_pllv3_is_prepared, > .recalc_rate = clk_pllv3_recalc_rate, > .round_rate = clk_pllv3_round_rate, > .set_rate = clk_pllv3_set_rate, > @@ -193,6 +204,7 @@ static int clk_pllv3_sys_set_rate(struct clk_hw *hw, unsigned long rate, > static const struct clk_ops clk_pllv3_sys_ops = { > .prepare = clk_pllv3_prepare, > .unprepare = clk_pllv3_unprepare, > + .is_prepared = clk_pllv3_is_prepared, > .recalc_rate = clk_pllv3_sys_recalc_rate, > .round_rate = clk_pllv3_sys_round_rate, > .set_rate = clk_pllv3_sys_set_rate, > @@ -265,6 +277,7 @@ static int clk_pllv3_av_set_rate(struct clk_hw *hw, unsigned long rate, > static const struct clk_ops clk_pllv3_av_ops = { > .prepare = clk_pllv3_prepare, > .unprepare = clk_pllv3_unprepare, > + .is_prepared = clk_pllv3_is_prepared, > .recalc_rate = clk_pllv3_av_recalc_rate, > .round_rate = clk_pllv3_av_round_rate, > .set_rate = clk_pllv3_av_set_rate, > @@ -279,6 +292,7 @@ static unsigned long clk_pllv3_enet_recalc_rate(struct clk_hw *hw, > static const struct clk_ops clk_pllv3_enet_ops = { > .prepare = clk_pllv3_prepare, > .unprepare = clk_pllv3_unprepare, > + .is_prepared = clk_pllv3_is_prepared, > .recalc_rate = clk_pllv3_enet_recalc_rate, > }; > > -- > 1.9.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >