From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752388AbbKXHK4 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 24 Nov 2015 02:10:56 -0500
Received: from mail-pa0-f42.google.com ([209.85.220.42]:33786 "EHLO
	mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751616AbbKXHKz (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 24 Nov 2015 02:10:55 -0500
Date: Tue, 24 Nov 2015 16:10:46 +0900
From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
        Kyeongdon Kim <kyeongdon.kim@lge.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH 1/3] zram/zcomp: use GFP_NOIO to allocate streams
Message-ID: <20151124071046.GD7708@blaptop>
References: <1448337696-10689-1-git-send-email-minchan@kernel.org>
 <20151124060037.GI705@swordfish>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151124060037.GI705@swordfish>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 24, 2015 at 03:00:37PM +0900, Sergey Senozhatsky wrote:
> [..]
> >  static struct zcomp_strm *zcomp_strm_alloc(struct zcomp *comp)
> >  {
> > -       struct zcomp_strm *zstrm = kmalloc(sizeof(*zstrm), GFP_KERNEL);
> > +       struct zcomp_strm *zstrm = kmalloc(sizeof(*zstrm), GFP_NOIO);
> >         if (!zstrm)
> >                 return NULL;
> > 
> > @@ -85,7 +85,7 @@ static struct zcomp_strm *zcomp_strm_alloc(struct zcomp *comp)
> >          * allocate 2 pages. 1 for compressed data, plus 1 extra for the
> >          * case when compressed size is larger than the original one
> >          */
> > -       zstrm->buffer = (void *)__get_free_pages(GFP_KERNEL | __GFP_ZERO, 1);
> > +       zstrm->buffer = (void *)__get_free_pages(GFP_NOIO | __GFP_ZERO, 1);
> >         if (!zstrm->private || !zstrm->buffer) {
> >                 zcomp_strm_free(comp, zstrm);
> >                 zstrm = NULL;
> 
> hm... this is not enough.
> we allocate
> 
> 	stream GFP_NOIO
> 	stream private GFP_KERNEL    <<<< still old flags
> 	stream buffer
> 
> so my patch was something like this:

Oops, I missed that. Sorry.
I will include it in next spin.

Thanks!
-- 
Kind regards,
Minchan Kim