From: Christoph Hellwig <hch@lst.de>
To: Andreas Herrmann <aherrmann@suse.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [RFC] blk-mq and I/O scheduling
Date: Tue, 24 Nov 2015 09:19:32 +0100 [thread overview]
Message-ID: <20151124081932.GA30083@lst.de> (raw)
In-Reply-To: <20151119120235.GA7966@suselix.suse.de>
Hi Andreas,
I don't understand the time slicing algorithm to well, but from the
blk-mq integration perspective this looks nice, and anything that
helps improving blk-mq for spinning rust is useful.
As a nitpick some of the larger "if (use_time_slice)" blocks should
be moved into separate helper functions‥
next prev parent reply other threads:[~2015-11-24 8:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 12:02 [RFC] blk-mq and I/O scheduling Andreas Herrmann
2015-11-24 8:19 ` Christoph Hellwig [this message]
2015-12-01 7:37 ` Andreas Herrmann
2015-11-25 19:47 ` Jens Axboe
2015-12-01 7:43 ` Andreas Herrmann
2016-02-01 22:43 ` [RFC PATCH v2] blk-mq: Introduce per sw queue time-slice Andreas Herrmann
2016-02-01 22:46 ` Andreas Herrmann
2016-02-09 17:12 ` Andreas Herrmann
2016-02-09 17:41 ` Markus Trippelsdorf
2016-02-10 19:34 ` Andreas Herrmann
2016-02-10 19:47 ` Markus Trippelsdorf
2016-02-10 22:09 ` Andreas Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151124081932.GA30083@lst.de \
--to=hch@lst.de \
--cc=aherrmann@suse.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).