From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752778AbbKXI2G (ORCPT ); Tue, 24 Nov 2015 03:28:06 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:38886 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752571AbbKXI2C (ORCPT ); Tue, 24 Nov 2015 03:28:02 -0500 Date: Tue, 24 Nov 2015 09:27:57 +0100 From: Ingo Molnar To: Kees Cook Cc: Dan Williams , "linux-kernel@vger.kernel.org" , linux-arch , Russell King , Arnd Bergmann , Greg Kroah-Hartman , Catalin Marinas , "linux-nvdimm@lists.01.org" , Heiko Carstens , Andrew Morton , Will Deacon , Ingo Molnar , Benjamin Herrenschmidt , "H. Peter Anvin" , Martin Schwidefsky , Thomas Gleixner , "David S. Miller" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 1/2] arch: consolidate CONFIG_STRICT_DEVM in lib/Kconfig.debug Message-ID: <20151124082757.GB23624@gmail.com> References: <20151122035702.9313.52457.stgit@dwillia2-desk3.jf.intel.com> <20151123081235.GA23661@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Kees Cook wrote: > On Mon, Nov 23, 2015 at 9:12 AM, Dan Williams wrote: > > On Mon, Nov 23, 2015 at 12:12 AM, Ingo Molnar wrote: > >> > >> * Dan Williams wrote: > >> > >>> Let all the archs that implement CONFIG_STRICT_DEVM use a common > >>> definition in lib/Kconfig.debug. > >> > >> For the x86 bit: > >> > >> Acked-by: Ingo Molnar > >> > >>> Note, the 'depends on !SPARC' is due to sparc not implementing > >>> devmem_is_allowed(). > >> > >> Maybe that should be converted into a helper Kconfig switch for architectures to > >> opt in to /dev/mem restrictions? > > > > Sure, easy enough to add a ARCH_HAS_DEVMEM_IS_ALLOWED opt-in. > > Is there some hidden meaning about the difference between ARCH_HAS_... > and HAVE_ARCH_... and HAVE_... ? There's also the double underscore variants such as __HAVE_ARCH_STRNCASECMP! ;-) It's all just nonsensical historic muck: because no-one ever was confronted with the messy global picture. Today you can run Documentation/features/list-arch.sh and wonder at the zoo of options ;-) Thanks, Ingo