From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753791AbbKXOR3 (ORCPT ); Tue, 24 Nov 2015 09:17:29 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:40560 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752674AbbKXOR2 (ORCPT ); Tue, 24 Nov 2015 09:17:28 -0500 Date: Tue, 24 Nov 2015 15:17:23 +0100 From: Andrew Lunn To: Arnd Bergmann Cc: "David S. Miller" , netdev@vger.kernel.org, Florian Fainelli , Russell King , linux-kernel@vger.kernel.org, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] net: dsa: include gpio consumer header file Message-ID: <20151124141723.GA26341@lunn.ch> References: <6383467.TZ5s6u4A6T@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6383467.TZ5s6u4A6T@wuerfel> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 24, 2015 at 12:34:49PM +0100, Arnd Bergmann wrote: > After the introduction of the switch gpio reset API, I'm getting > build errors in configurations that disable CONFIG_GPIOLIB: > > net/dsa/dsa.c:783:16: error: implicit declaration of function 'gpio_to_desc' [-Werror=implicit-function-declaration] > > The reason is that linux/gpio/consumer.h is not automatically > included without gpiolib support. This adds an explicit #include > statement to make it compile in all configurations. The reset > functionality will not work without gpiolib, which is what you > get when disabling the feature. > > As far as I can tell, gpiolib is supported on all architectures > on which you can have DSA at the moment. > > Signed-off-by: Arnd Bergmann > Fixes: cc30c16344fc ("net: dsa: Add support for a switch reset gpio") Hi Arnd Thanks for this. I had something similar in my github overnight so that 0-day would build test it. Acked-by: Andrew Lunn Andrew