From: Alban <albeu@free.fr>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Aban Bedel <albeu@free.fr>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reset: ath79: Add system restart support
Date: Tue, 24 Nov 2015 19:33:49 +0100 [thread overview]
Message-ID: <20151124193349.6ddc4c0b@tock> (raw)
In-Reply-To: <1448366506.3346.72.camel@pengutronix.de>
On Tue, 24 Nov 2015 13:01:46 +0100
Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Hi Alban,
>
> Am Dienstag, den 24.11.2015, 01:00 +0100 schrieb Alban Bedel:
> > Add a system restart handler that use the FULL_CHIP_RESET bit of the
> > reset controller.
> >
> > Signed-off-by: Alban Bedel <albeu@free.fr>
>
> Applied, thanks.
Thanks to you :)
> Btw, should this driver #include <linux/io.h> for readl/writel?
Good question :) It turns out to be a MIPS glitch, asm/io.h is included
by asm/page.h which here come from linux/module.h. But we shouldn't
rely on this glitch and the driver should #include <linux/io.h>.
I'll fix this and add support for CONFIG_COMPILE_TEST to better catch
this kind of bugs in the future.
Alban
prev parent reply other threads:[~2015-11-24 18:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 0:00 [PATCH] reset: ath79: Add system restart support Alban Bedel
2015-11-24 12:01 ` Philipp Zabel
2015-11-24 18:33 ` Alban [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151124193349.6ddc4c0b@tock \
--to=albeu@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox