From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932492AbbKXXnZ (ORCPT ); Tue, 24 Nov 2015 18:43:25 -0500 Received: from mail.kernel.org ([198.145.29.136]:48200 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754190AbbKXXnX (ORCPT ); Tue, 24 Nov 2015 18:43:23 -0500 Date: Tue, 24 Nov 2015 17:43:19 -0600 From: Bjorn Helgaas To: WingMan Kwok Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, kishon@ti.com, rogerq@ti.com, m-karicheri2@ti.com, bhelgaas@google.com, ssantosh@kernel.org, linux@arm.linux.org.uk, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: keystone: dts: add PCI serdes driver bindings Message-ID: <20151124234319.GG17377@localhost> References: <1444919230-30932-1-git-send-email-w-kwok2@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444919230-30932-1-git-send-email-w-kwok2@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi WingMan, On Thu, Oct 15, 2015 at 10:27:10AM -0400, WingMan Kwok wrote: > This patch adds the required PCI serdes bindings whcih can then be > enabled by setting the corresponding statuses to "ok" in order to > configure and start the PCI serdes. > > This patch depends on the updates to the Keystone PCIe host driver > and common serdes driver patch series that is submitted separately. > > Signed-off-by: WingMan Kwok Is there a reason to separate the binding update from the PCIe host driver update? It would make sense to me to have them in the same patch to make it easier to keep them consistent. Bjorn > --- > arch/arm/boot/dts/k2e.dtsi | 21 +++++++++++++++++++++ > arch/arm/boot/dts/keystone.dtsi | 21 +++++++++++++++++++++ > 2 files changed, 42 insertions(+) > > diff --git a/arch/arm/boot/dts/k2e.dtsi b/arch/arm/boot/dts/k2e.dtsi > index 675fb8e..3b36575 100644 > --- a/arch/arm/boot/dts/k2e.dtsi > +++ b/arch/arm/boot/dts/k2e.dtsi > @@ -86,6 +86,16 @@ > gpio,syscon-dev = <&devctrl 0x240>; > }; > > + pcie1_phy: pciephy@2326000 { > + #phy-cells = <0>; > + compatible = "ti,keystone-serdes-pcie"; > + reg = <0x02326000 0x4000>; > + reg-names = "serdes"; > + link-rate-kbps = <5000000>; > + num-lanes = <2>; > + status = "disabled"; > + }; > + > pcie1: pcie@21020000 { > compatible = "ti,keystone-pcie","snps,dw-pcie"; > clocks = <&clkpcie1>; > @@ -130,6 +140,17 @@ > , > ; > }; > + > + /* PCIE phy */ > + serdeses { > + #address-cells = <1>; > + #size-cells = <0>; > + serdes@0 { > + reg = <0>; > + phys = <&pcie1_phy>; > + }; > + }; > + > }; > > mdio: mdio@24200f00 { > diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi > index 72816d6..6566cc4 100644 > --- a/arch/arm/boot/dts/keystone.dtsi > +++ b/arch/arm/boot/dts/keystone.dtsi > @@ -275,6 +275,16 @@ > ti,syscon-dev = <&devctrl 0x2a0>; > }; > > + pcie0_phy: pciephy@2320000 { > + #phy-cells = <0>; > + compatible = "ti,keystone-serdes-pcie"; > + reg = <0x02320000 0x4000>; > + reg-names = "serdes"; > + link-rate-kbps = <5000000>; > + num-lanes = <2>; > + status = "disabled"; > + }; > + > pcie0: pcie@21800000 { > compatible = "ti,keystone-pcie", "snps,dw-pcie"; > clocks = <&clkpcie>; > @@ -319,6 +329,17 @@ > , > ; > }; > + > + /* PCIE phy */ > + serdeses { > + #address-cells = <1>; > + #size-cells = <0>; > + serdes@0 { > + reg = <0>; > + phys = <&pcie0_phy>; > + }; > + }; > + > }; > }; > }; > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html