From: Borislav Petkov <bp@alien8.de>
To: "河合英宏 / KAWAI，HIDEHIRO" <hidehiro.kawai.ez@hitachi.com>
Cc: "Jonathan Corbet" <corbet@lwn.net>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Vivek Goyal" <vgoyal@redhat.com>, "Baoquan He" <bhe@redhat.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Michal Hocko" <mhocko@kernel.org>,
"Ingo Molnar" <mingo@redhat.com>,
"平松雅巳 / HIRAMATU，MASAMI" <masami.hiramatsu.pt@hitachi.com>
Subject: Re: [V5 PATCH 2/4] panic/x86: Allow cpus to save registers even if they are looping in NMI context
Date: Wed, 25 Nov 2015 10:57:58 +0100 [thread overview]
Message-ID: <20151125095758.GC29499@pd.tnic> (raw)
In-Reply-To: <04EAB7311EE43145B2D3536183D1A84454A2B929@GSjpTKYDCembx31.service.hitachi.net>
On Wed, Nov 25, 2015 at 09:46:37AM +0000, 河合英宏 / KAWAI，HIDEHIRO wrote:
> Does *old* code mean the code without this patch *series* ?
Yes.
> I prefer this, but we might want to add some more prefix or suffix.
> For example, "conditionally_run_crash_nmi_callback".
That's unnecessary IMO. If you need to express that, you could write
that in a comment above the function definition. Anyone who looks at
the code then will know that it is conditional, like so many other
kernel functions. :)
> Thanks for your deep review!
Thanks for the patience!
:-)
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2015-11-25 9:58 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 9:36 [V5 PATCH 0/4] Fix race issues among panic, NMI and crash_kexec Hidehiro Kawai
2015-11-20 9:36 ` [V5 PATCH 1/4] panic/x86: Fix re-entrance problem due to panic on NMI Hidehiro Kawai
2015-11-23 18:49 ` Borislav Petkov
2015-11-24 4:06 ` 河合英宏 / KAWAI，HIDEHIRO
2015-11-24 12:45 ` Michal Hocko
2015-11-24 15:05 ` Steven Rostedt
2015-11-24 15:12 ` Steven Rostedt
2015-11-24 20:27 ` Michal Hocko
2015-11-24 20:45 ` Steven Rostedt
2015-11-20 9:36 ` [V5 PATCH 2/4] panic/x86: Allow cpus to save registers even if they are looping in NMI context Hidehiro Kawai
2015-11-24 10:48 ` Borislav Petkov
2015-11-24 19:37 ` Steven Rostedt
2015-11-24 20:16 ` Borislav Petkov
2015-11-25 5:57 ` 河合英宏 / KAWAI，HIDEHIRO
2015-11-25 5:51 ` 河合英宏 / KAWAI，HIDEHIRO
2015-11-25 8:56 ` Borislav Petkov
2015-11-25 9:46 ` 河合英宏 / KAWAI，HIDEHIRO
2015-11-25 9:57 ` Borislav Petkov [this message]
2015-11-25 15:11 ` 河合英宏 / KAWAI，HIDEHIRO
2015-11-24 12:58 ` Michal Hocko
2015-12-03 2:23 ` 河合英宏 / KAWAI，HIDEHIRO
2015-11-20 9:36 ` [V5 PATCH 3/4] kexec: Fix race between panic() and crash_kexec() called directly Hidehiro Kawai
2015-11-24 13:05 ` Michal Hocko
2015-11-24 20:35 ` Steven Rostedt
2015-11-25 6:28 ` 河合英宏 / KAWAI，HIDEHIRO
2015-11-25 9:54 ` Borislav Petkov
2015-12-02 11:57 ` 河合英宏 / KAWAI，HIDEHIRO
2015-12-02 15:40 ` Borislav Petkov
2015-12-03 2:01 ` 河合英宏 / KAWAI，HIDEHIRO
2015-12-03 9:35 ` Borislav Petkov
2015-12-03 11:29 ` 河合英宏 / KAWAI，HIDEHIRO
2015-12-03 12:22 ` Borislav Petkov
2015-11-20 9:36 ` [V5 PATCH 4/4] x86/apic: Introduce apic_extnmi boot option Hidehiro Kawai
2015-11-25 11:49 ` Borislav Petkov
2015-11-25 15:29 ` 河合英宏 / KAWAI，HIDEHIRO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151125095758.GC29499@pd.tnic \
--to=bp@alien8.de \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=corbet@lwn.net \
--cc=ebiederm@xmission.com \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mhocko@kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox