The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: Christoph Lameter <cl@linux.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/vmstat: retrieve more accurate vmstat value
Date: Wed, 25 Nov 2015 19:03:50 +0100	[thread overview]
Message-ID: <20151125180350.GT27283@dhcp22.suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.20.1511251002380.31590@east.gentwo.org>

On Wed 25-11-15 10:04:44, Christoph Lameter wrote:
> On Wed, 25 Nov 2015, Joonsoo Kim wrote:
> 
> > I think that maintaining duplicate counter to guarantee accuracy isn't
> > reasonable solution. It would cause more overhead to the system.
> 
> Simply remove the counter from the vmstat handling and do it differently
> then.

We definitely do not want yet another set of counters. vmstat counters
are not only to be exported into the userspace. We have in kernel users
as well. I do agree that there are users who can cope with some level of
imprecision though and those which depend on the accuracy can use
zone_page_state_snapshot which doesn't impose any overhead on others.
[...]
-- 
Michal Hocko
SUSE Labs

  reply	other threads:[~2015-11-25 18:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-24  6:22 [PATCH] mm/vmstat: retrieve more accurate vmstat value Joonsoo Kim
2015-11-24 15:36 ` Christoph Lameter
2015-11-25  2:57   ` Joonsoo Kim
2015-11-25 16:04     ` Christoph Lameter
2015-11-25 18:03       ` Michal Hocko [this message]
2015-11-25 18:26         ` Christoph Lameter
2015-11-26  1:52       ` Joonsoo Kim
2015-12-03  4:14         ` Joonsoo Kim
2016-01-27 23:13         ` David Rientjes
2016-01-28  5:08           ` Joonsoo Kim
2015-11-25 12:00 ` Michal Hocko
2015-11-25 13:43   ` Vlastimil Babka
2015-11-25 13:47     ` Michal Hocko
2015-11-26  1:56   ` Joonsoo Kim
2015-11-26  5:03     ` vinayak menon
2015-11-26 15:03     ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151125180350.GT27283@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox