From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752841AbbKZHqw (ORCPT ); Thu, 26 Nov 2015 02:46:52 -0500 Received: from mail-lf0-f54.google.com ([209.85.215.54]:35955 "EHLO mail-lf0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752737AbbKZHqu (ORCPT ); Thu, 26 Nov 2015 02:46:50 -0500 Date: Thu, 26 Nov 2015 08:47:18 +0100 From: Johan Hovold To: Andy Shevchenko , Konstantin Shkolnyy Cc: johan@kernel.org, USB , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] USB: serial: cp210x: Add tx_empty() Message-ID: <20151126074718.GE11484@localhost> References: <1448404121-12964-1-git-send-email-konstantin.shkolnyy@gmail.com> <20151126073512.GD11484@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151126073512.GD11484@localhost> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 26, 2015 at 08:35:12AM +0100, Johan Hovold wrote: > On Wed, Nov 25, 2015 at 10:26:12PM +0200, Andy Shevchenko wrote: > > On Wed, Nov 25, 2015 at 12:28 AM, Konstantin Shkolnyy > > wrote: > > > Added tx_empty callback needed for generic wait-until-sent support. > > > Without this function, when the port is closed usbserial can't know that > > > there are still data in the chip's transmit FIFO. The chip gets disabled > > > and untransmitted data lost. When the actual byte count is reported by > > > tx-empty the close can be delayed until all data are sent. > > Btw, can be count left uninitialized? > > Yes, but that's not an issue. Clearly separating the success and errors > paths as I suggested above would make that more obvious however. > > I'll fix that up before applying. Now applied, thanks. Johan