From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752214AbbKZLAH (ORCPT ); Thu, 26 Nov 2015 06:00:07 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:36738 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbbKZLAF (ORCPT ); Thu, 26 Nov 2015 06:00:05 -0500 Date: Thu, 26 Nov 2015 12:00:00 +0100 From: Ingo Molnar To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, David Ahern , Jan Kratochvil , Masami Hiramatsu , Milian Wolff , Namhyung Kim , Peter Zijlstra , Taeung Song , Wang Nan , Arnaldo Carvalho de Melo Subject: Re: [GIT PULL 0/7] perf/core improvements and fixes Message-ID: <20151126110000.GC8745@gmail.com> References: <1448315634-13592-1-git-send-email-acme@kernel.org> <20151124081042.GA3651@gmail.com> <20151124082805.GB30337@krava.brq.redhat.com> <20151124084210.GA31160@gmail.com> <20151124092618.GA5359@krava.brq.redhat.com> <20151124094729.GB5359@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151124094729.GB5359@krava.brq.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Jiri Olsa wrote: > I think I found one race.. > - having install-traceevent-plugins depend on $(LIBTRACEEVENT), > plugins will not be built as its prereq. and the target > install-traceevent-plugins itself will trigger plugins build > - but plugins build is also triggered by perf build itself > via libtraceevent_plugins target > > so those 2 might race.. but as I said, I've never reproduced ;-) > > Could you please give it a try? > > thanks, > jirka > > > --- > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf > index 0d19d5447d6c..929a32ba15f5 100644 > --- a/tools/perf/Makefile.perf > +++ b/tools/perf/Makefile.perf > @@ -420,7 +420,7 @@ $(LIBTRACEEVENT)-clean: > $(call QUIET_CLEAN, libtraceevent) > $(Q)$(MAKE) -C $(TRACE_EVENT_DIR) O=$(OUTPUT) clean >/dev/null > > -install-traceevent-plugins: $(LIBTRACEEVENT) > +install-traceevent-plugins: libtraceevent_plugins > $(Q)$(MAKE) -C $(TRACE_EVENT_DIR) $(LIBTRACEEVENT_FLAGS) O=$(OUTPUT) install_plugins > Ok, so I tried this fix with my 'sleep 1' hack to make the race easier to trigger, and without your fix it still fails fairly quickly: triton:~/tip/tools/perf> while : ; do echo -n "$(date) "; make clean install V=1 >/tmp/FAIL.log 2>&1 && echo pass || { echo 'FAIL!'; break; } done Thu Nov 26 11:54:36 CET 2015 pass Thu Nov 26 11:54:47 CET 2015 FAIL! but with your fix applied it passes a reasonable number of builds: triton:~/tip/tools/perf> while : ; do echo -n "$(date) "; make clean install V=1 >/tmp/FAIL.log 2>&1 && echo pass || { echo 'FAIL!'; break; } done Thu Nov 26 11:55:12 CET 2015 pass Thu Nov 26 11:55:25 CET 2015 pass Thu Nov 26 11:55:36 CET 2015 pass Thu Nov 26 11:55:47 CET 2015 pass Thu Nov 26 11:55:58 CET 2015 pass Thu Nov 26 11:56:09 CET 2015 pass Thu Nov 26 11:56:21 CET 2015 pass Thu Nov 26 11:56:32 CET 2015 pass Thu Nov 26 11:56:44 CET 2015 pass Thu Nov 26 11:56:55 CET 2015 pass Thu Nov 26 11:57:06 CET 2015 pass Thu Nov 26 11:57:18 CET 2015 pass Thu Nov 26 11:57:29 CET 2015 pass Thu Nov 26 11:57:40 CET 2015 pass Thu Nov 26 11:57:51 CET 2015 pass Thu Nov 26 11:58:03 CET 2015 pass So I think the bug is fixed for good: Tested-by: Ingo Molnar ( I'll keep it running some longer and will let you know if there's any failure. Consider it fixed if I don't send any update. ) Thanks, Ingo