Re: [PATCH 1/3] net-PPP: Deletion of unnecessary checks before the function call "kfree"

SF Markus Elfring
2014-12-01T15:01:08Z

>> diff --git a/drivers/net/ppp/ppp_mppe.c b/drivers/net/ppp/ppp_mppe.c
>> index 911b216..7e44212 100644
>> --- a/drivers/net/ppp/ppp_mppe.c
>> +++ b/drivers/net/ppp/ppp_mppe.c
>> @@ -238,8 +238,7 @@ static void *mppe_alloc(unsigned char *options, int optlen)
>> return (void *)state;
>>
>> out_free:
>> - if (state->sha1_digest)
>> - kfree(state->sha1_digest);
>> + kfree(state->sha1_digest);
>
> Please keep this line aligned to the others.

Can it be that the previous source code contained unwanted space
characters at this place?
Do you want indentation fixes as a separate update step?

Regards,
Markus