Re: [PATCH] UBIFS: Delete unnecessary checks before the function call "iput"

Richard Weinberger
2015-11-06T22:15:36Z

On Wed, Nov 4, 2015 at 8:10 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 4 Nov 2015 20:00:42 +0100
>
> The iput() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> fs/ubifs/recovery.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/ubifs/recovery.c b/fs/ubifs/recovery.c
> index 2a1f0bc..586d593 100644
> --- a/fs/ubifs/recovery.c
> +++ b/fs/ubifs/recovery.c
> @@ -1331,8 +1331,7 @@ void ubifs_destroy_size_tree(struct ubifs_info *c)
> struct size_entry *e, *n;
>
> rbtree_postorder_for_each_entry_safe(e, n, &c->size_tree, rb) {
> - if (e->inode)
> - iput(e->inode);
> + iput(e->inode);
> kfree(e);
> }
>
> @@ -1533,8 +1532,7 @@ int ubifs_recover_size(struct ubifs_info *c)
> err = fix_size_in_place(c, e);
> if (err)
> return err;
> - if (e->inode)
> - iput(e->inode);
> + iput(e->inode);
> }
> }

Applied!

--
Thanks,
//richard