Re: XFS: Fine-tuning for checks before the function call "xfs_qm_dqrele"?

SF Markus Elfring
2015-07-01T07:50:18Z

> xfs_dqrele_inode() gets called on every inode in the inode cache,
> and this change results in a cacheline in every inode being dirtied
> even if they don't have dquots attached. Given the inode cache can
> hold tens to hundreds of millions of inodes on large machines, we
> don't want to dirty any cachelines we don't need to while walking
> the inode cache and releasing dquots...

Would it make sense to annotate checks before such function calls
as "LIKELY"?

Regards,
Markus