Re: staging: wilc1000: One function call less in mac_ioctl() after error detection

SF Markus Elfring
2015-07-08T08:40:58Z

>> The kfree() function was called in two cases by the mac_ioctl() function
>> during error handling even if the passed variable did not contain a pointer
>> for a valid data item.
>>
>> * This implementation detail could be improved by the introduction
>> of another jump label.
>>
>> * Drop an unnecessary initialisation for the variable "buff" then.
>
> That's a different issue, please fix it in a separate patch.

I have got an other opinion here.
This update suggestion depends on a small source code clean-up
from the previous patch, doesn't it?

Do you want that I split the second suggestion from this series
into more steps?

Regards,
Markus