From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753446AbbKZUVy (ORCPT ); Thu, 26 Nov 2015 15:21:54 -0500 Received: from imap.thunk.org ([74.207.234.97]:53486 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752640AbbKZUVw (ORCPT ); Thu, 26 Nov 2015 15:21:52 -0500 Date: Thu, 26 Nov 2015 15:21:44 -0500 From: "Theodore Ts'o" To: Al Viro Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [[PATCH] fix an endianness bug in ext4_encrypted_zeroout() Message-ID: <20151126202144.GD2632@thunk.org> Mail-Followup-To: Theodore Ts'o , Al Viro , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <20151126160434.GU22011@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151126160434.GU22011@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 26, 2015 at 04:04:34PM +0000, Al Viro wrote: > ex->ee_block is not host-endian (note that accesses of other fields > of *ex right next to that line go through the helpers that do proper > conversion from little-endian to host-endian; it might make sense > to add similar for ->ee_block to avoid reintroducing that kind of > bugs...) > > Cc: stable@vger.kernel.org # v4.1+ > Signed-off-by: Al Viro Thanks for catching this! Applied. - Ted