* [bug] mei_fasync() bogosity
@ 2015-11-27 4:22 Al Viro
0 siblings, 0 replies; only message in thread
From: Al Viro @ 2015-11-27 4:22 UTC (permalink / raw)
To: Tomas Winkler; +Cc: Greg Kroah-Hartman, linux-kernel
in "mei: implement fasync for event notification" a ->fasync() instance is
added as
static int mei_fasync(int fd, struct file *file, int band)
{
struct mei_cl *cl = file->private_data;
if (!mei_cl_is_connected(cl))
return POLLERR;
return fasync_helper(fd, file, band, &cl->ev_async);
}
Valid return values for ->fasync() are 0, 1 and -E...; 8 (aka POLLERR) is not.
What had been intended there? -ENODEV? Some other error? As it is, the
thing is broken.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-11-27 4:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-27 4:22 [bug] mei_fasync() bogosity Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox