From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754457AbbK0Jbd (ORCPT ); Fri, 27 Nov 2015 04:31:33 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:37960 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754185AbbK0Jb3 (ORCPT ); Fri, 27 Nov 2015 04:31:29 -0500 Date: Fri, 27 Nov 2015 10:31:25 +0100 From: Ingo Molnar To: Rasmus Villemoes Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, Borislav Petkov , Toshi Kani Subject: Re: [PATCH] x86, mtrr: mark range_new in mtrr_calc_range_state() as __initdata Message-ID: <20151127093125.GA28272@gmail.com> References: <1447408073-25059-1-git-send-email-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447408073-25059-1-git-send-email-linux@rasmusvillemoes.dk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Rasmus Villemoes wrote: > range_new doesn't seem to be used after init. It is only passed to > memset, sum_ranges, memcmp and x86_get_mtrr_mem_range, the latter of > which also only passes it on to various *range* library functions. So > mark it __initdata to free up an extra page after init. > > nr_range_new is unconditionally assigned to before it is read, so > there's no point in having it static. > > Signed-off-by: Rasmus Villemoes > --- > arch/x86/kernel/cpu/mtrr/cleanup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/cpu/mtrr/cleanup.c b/arch/x86/kernel/cpu/mtrr/cleanup.c > index 70d7c93f4550..b1a9ad366f67 100644 > --- a/arch/x86/kernel/cpu/mtrr/cleanup.c > +++ b/arch/x86/kernel/cpu/mtrr/cleanup.c > @@ -593,9 +593,9 @@ mtrr_calc_range_state(u64 chunk_size, u64 gran_size, > unsigned long x_remove_base, > unsigned long x_remove_size, int i) > { > - static struct range range_new[RANGE_NUM]; > + static struct range range_new[RANGE_NUM] __initdata; > unsigned long range_sums_new; > - static int nr_range_new; > + int nr_range_new; > int num_reg; > > /* Convert ranges to var ranges state: */ So this static variable actually surprised me - I never realized it was there - and it's not some simple 'once' flag, but something that is essential semantics. So marking it __initdata is correct, but please also move it out of function local variables scope, into file scope - and name it properly as well, like mtrr_new_range[] or so? Thanks, Ingo