From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755190AbbK0UiJ (ORCPT ); Fri, 27 Nov 2015 15:38:09 -0500 Received: from mail.kernel.org ([198.145.29.136]:54564 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754450AbbK0UiF (ORCPT ); Fri, 27 Nov 2015 15:38:05 -0500 Date: Fri, 27 Nov 2015 14:38:00 -0600 From: Rob Herring To: Biao Huang Cc: Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Matthias Brugger , Linus Walleij , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, srv_heupstream@mediatek.com Subject: Re: [PATCH 2/5] dt-bindings: mediatek: Modify pinctrl bindings for mt2701 Message-ID: <20151127203800.GA9092@rob-hp-laptop> References: <1448527472-20651-1-git-send-email-biao.huang@mediatek.com> <1448527472-20651-3-git-send-email-biao.huang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448527472-20651-3-git-send-email-biao.huang@mediatek.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 26, 2015 at 04:44:29PM +0800, Biao Huang wrote: > Signed-off-by: Biao Huang > --- > .../devicetree/bindings/pinctrl/pinctrl-mt65xx.txt | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt > index 0480bc3..ca6a27a 100644 > --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt > @@ -4,10 +4,11 @@ The Mediatek's Pin controller is used to control SoC pins. > > Required properties: > - compatible: value should be one of the following. > - (a) "mediatek,mt8135-pinctrl", compatible with mt8135 pinctrl. > - (b) "mediatek,mt8173-pinctrl", compatible with mt8173 pinctrl. > - (c) "mediatek,mt6397-pinctrl", compatible with mt6397 pinctrl. > - (d) "mediatek,mt8127-pinctrl", compatible with mt8127 pinctrl. > + (a) "mediatek,mt2701-pinctrl", compatible with mt2701 pinctrl. > + (b) "mediatek,mt6397-pinctrl", compatible with mt6397 pinctrl. > + (c) "mediatek,mt8135-pinctrl", compatible with mt8135 pinctrl. > + (d) "mediatek,mt8173-pinctrl", compatible with mt8173 pinctrl. > + (e) "mediatek,mt8127-pinctrl", compatible with mt8127 pinctrl. If you were trying to sort these, they still aren't quite sorted. There is no point in sorting if you number (or letter) them because you will have to update many lines on any change. So drop the (a), (b), (c), etc. Rob > - pins-are-numbered: Specify the subnodes are using numbered pinmux to > specify pins. > - gpio-controller : Marks the device node as a gpio controller. > -- > 1.7.9.5 >