From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751809AbbK1Avj (ORCPT ); Fri, 27 Nov 2015 19:51:39 -0500 Received: from mail.kernel.org ([198.145.29.136]:34027 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009AbbK1Avg (ORCPT ); Fri, 27 Nov 2015 19:51:36 -0500 Date: Fri, 27 Nov 2015 21:51:31 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern Subject: Re: [PATCH 2/3] perf hist: Do not skip elided fields when processing samples Message-ID: <20151128005131.GK5934@kernel.org> References: <1448645559-31167-1-git-send-email-namhyung@kernel.org> <1448645559-31167-2-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448645559-31167-2-git-send-email-namhyung@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sat, Nov 28, 2015 at 02:32:38AM +0900, Namhyung Kim escreveu: > If user gives a filter, perf marks the corresponding column elided and > omits the output. But it should process and aggregates samples using > the field, otherwise samples will be aggregated as if the column was not > there resulted in incorrect output. Thanks, applied, I've tested it and it now seems to work in both the --stdio and --tui interfaces, good job! - Arnaldo